Retired
Sudoku Solution Validator (retired)
12,440 of 42,838xDranik
Loading description...
Data Structures
Algorithms
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
just one random test (below) failing, wants a false. tested manually and on a sudoku solver, the board is correct. it should be true, but expects a false.
{1, 2, 3, 4, 5, 6, 7, 8, 9} {2, 3, 1, 5, 6, 4, 8, 9, 7} {3, 1, 2, 6, 4, 5, 9, 7, 8} {4, 5, 6, 7, 8, 9, 1, 2, 3} {5, 6, 4, 8, 9, 7, 2, 3, 1} {6, 4, 5, 9, 7, 8, 3, 1, 2} {7, 8, 9, 1, 2, 3, 4, 5, 6} {8, 9, 7, 2, 3, 1, 5, 6, 4} {9, 7, 8, 3, 1, 2, 6, 4, 5}
Read the task carefully. This is not a valid 3x3 subgrid:
Expected 'false' on input of < pre>1 2 3 4 5 6 7 8 9| |2 3 1 5 6 4 8 9 7| |3 1 2 6 4 5 9 7 8| |4 5 6 7 8 9 1 2 3| |5 6 4 8 9 7 2 3 1| |6 4 5 9 7 8 3 1 2| |7 8 9 1 2 3 4 5 6| |8 9 7 2 3 1 5 6 4| |9 7 8 3 1 2 6 4 5|< /pre>: expected true to equal false
It's should return true... but why false?
Because of that.
My solution that checks only if the 3x3 squares are valid passes all the tests, I do not beleive that should work as I would still need to check all of the rows and columns.
This one was a challenge for sure, but very much enjoyed!
This kata is a subject to deduplication process here: https://github.com/codewars/content-issues/issues/171.
Please join the discussion to help us identify duplicate kata and retire them.
Retired and replaced with Sudoku board validator.
i think the last test should be True expected not false! test.assert_equals(valid_solution([[1, 2, 3, 4, 5, 6, 7, 8, 9] ,[2, 3, 4, 5, 6, 7, 8, 9, 1] ,[3, 4, 5, 6, 7, 8, 9, 1, 2] ,[4, 5, 6, 7, 8, 9, 1, 2, 3] ,[5, 6, 7, 8, 9, 1, 2, 3, 4] ,[6, 7, 8, 9, 1, 2, 3, 4, 5] ,[7, 8, 9, 1, 2, 3, 4, 5, 6] ,[8, 9, 1, 2, 3, 4, 5, 6, 7] ,[9, 1, 2, 3, 4, 5, 6, 7, 8]]), False);
Hi @Gates_TN - check the top left 3x3 square of this grid: there are repeated 2's, 3's, 4's.
In sudoku also 3x3 grid can not have the same numbers
The whole thing is a 9x9 grid, which is made of 9 3x3 grids, in which all 9 numbers also have to be different
ahahaha yeah I thought so too and then I realised I don't know how sudoku wokrs lol
This naive solution of mine (checking only rows) https://www.codewars.com/kata/reviews/599ac698a48343e7b90027e1/groups/63ab134c94973c0001c7aba0 passes all tests. This should not happen.
This comment has been hidden.
Does that seem valid to you? Check the link with the rules of Sudoku.
This comment has been hidden.
There are already open issues about that, please don't open another.
Attempts will have few or sometimes no checks with zeros in them, leading to solutions that don't check for zeros to pass with a few tries
evary time checking returns different results 99/106, 105/106, 101/106... im almost sure that my code is 100% correct, can u fix this issue
Hi @VahanHoppar - In addition to the 6 fixed tests (they are the same each time you press Attempt) there are 100 randomly generated tests - they change/are different each time you press Attempt.
That's why there are different numbers of failed tests - you are probably missing a small element/edge case in your code that appears in a few random test cases.
The kata has been solved 17,000 times in Python so the tests are surely correct - if you want to debug you should print the random input to console, then see if you can understand why your code fails on it.
In other words: add
print(arr)inside your main function and look at the Codewars console for the failed tests you get - you can now try to understand why your code fails for this input.okay i got u, thank u <3 [[7, 4, 1, 8, 3, 2, 9, 5, 6], [5, 9, 3, 7, 6, 1, 8, 2, 4], [6, 8, 2, 9, 5, 4, 7, 1, 3], [3, 2, 5, 6, 8, 9, 4, 7, 1], [8, 6, 7, 4, 1, 3, 2, 9, 5], [4, 1, 9, 2, 7, 5, 6, 3, 8], [2, 3, 4, 1, 9, 6, 5, 8, 7], [1, 7, 6, 5, 2, 8, 3, 4, 9], [9, 5, 8, 3, 4, 7, 1, 6, 2]] i've chacked this one manually and with online ckacker,it's right solution but test returns False
Are you sure you're reading the logs ok? Take a look at this, the log appears above the test result: https://docs.codewars.com/training/troubleshooting#print-input
@VahanHoppar - no problem! You need to be more precise when you ask questions: for the test board that you just gave, the correct answer is indeed
True. My solution returnsTruefor it - and so does yours.So presumably, when you say "test returns False" you are not reading console logs correctly. This exact kata is the one used in the Troubleshooting guide where you will see that, when you print the inputs to console, the output that you print appears ABOVE the error message.
So rerun the tests, and make sure that you copy the input from above any Red/Incorrect error messages you get.
random test (below) failing, wants a false. tested manually and on a sudoku solver, the board is correct. it should be true, but expects a false.
[[3, 4, 5, 9, 7, 8, 6, 2, 1], [6, 7, 9, 2, 1, 4, 5, 8, 3], [2, 1, 8, 6, 3, 5, 7, 4, 9], [8, 2, 3, 5, 4, 9, 1, 7, 6], [5, 6, 1, 8, 2, 7, 3, 9, 4], [7, 9, 4, 3, 6, 1, 8, 5, 2], [1, 5, 7, 4, 9, 3, 2, 6, 8], [4, 3, 2, 7, 8, 6, 9, 1, 5], [9, 8, 6, 1, 5, 2, 4, 3, 7]]
Hey and welcome to Codewars - this test/board is indeed a correct Sudoku, so I'm guessing that you are reading the error logs/console incorrectly
The "Expected True to be False" is applying to the board above the error message - try reading this troubleshoot page then re-run your tests; make sure you are taking the sample test input from "above" the failed error message.
I won't close issue for now, but please update if that was indeed the problem.
you're totally correct, was looking at the wrong log. whoops! appreciate the help.
No worries!
Thanks for the quick reply and closing the Issue - hope you enjoy your time on Codewars, and congrats on solving (just saw your profile was updated - I saw you had a little typo with
boardvsrow;) ).By the way, there is a Discord if you want to join (link is in sidebar on the left), that's normally the best way to get a quick reply especially on weird timezones/weekdays depending on who is online.
4th test in python seems to be valid but asserts False I've passed every other test (including random) except this [1, 3, 2, 5, 7, 9, 4, 6, 8] [4, 9, 8, 2, 6, 1, 3, 7, 5] [7, 5, 6, 3, 8, 4, 2, 1, 9] [6, 4, 3, 1, 5, 8, 7, 9, 2] [5, 2, 1, 7, 9, 3, 8, 4, 6] [9, 8, 7, 4, 2, 6, 5, 3, 1] [2, 1, 4, 9, 3, 5, 6, 8, 7] [3, 6, 5, 8, 1, 7, 9, 2, 4] [8, 7, 9, 6, 4, 2, 1, 3, 5]
Please read the posts already here, it's been asked and answered many times.
And more
The last two columns are wrong, False is the right answer. Not a kata issue.
ty! appreciate your help
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
Hello everyone. Test Failed Test: {1, 2, 3, 4, 5, 6, 7, 8, 9} {2, 3, 1, 5, 6, 4, 8, 9, 7} {3, 1, 2, 6, 4, 5, 9, 7, 8} {4, 5, 6, 7, 8, 9, 1, 2, 3} {5, 6, 4, 8, 9, 7, 2, 3, 1} {6, 4, 5, 9, 7, 8, 3, 1, 2} {7, 8, 9, 1, 2, 3, 4, 5, 6} {8, 9, 7, 2, 3, 1, 5, 6, 4} {9, 7, 8, 3, 1, 2, 6, 4, 5} Expected: False But was: True This table is correct (I checked that manually) but I can't pass the test.
See the reply to pini85's question. Also the 3x3 blocks should contain nine different numbers. Your example table does not fulfill this requirement.
Not a kata issue, please read the posts below, it's been asked and answered many times.
Sorry guys! My bad, I was inattentive
This comment has been hidden.
Check the Sudoku rules: "...and each of the nine 3 × 3 subgrids that compose the grid (also called "boxes", "blocks", or "regions") contain all of the digits from 1 to 9." - https://en.wikipedia.org/wiki/Sudoku
This comment has been hidden.
I found it hard, especially having to figure out how to grab each of the blocks. Figured it out in the end, was so satisfying.
Updated to Scala 3 and added random tests
.
Hey guys! How can we see the inputs of the tests, which are not passed? I got 6 random test failed and can't understand what's wrong with the code
Hi, read this: https://docs.codewars.com/training/troubleshooting/#print-input
This comment has been hidden.
Make a fork, add the tests you want. And you're contradicting yourself saying how to pass the random tests. How is that not "giving any meaningful information about how to solve the problem"?
this kata so easy for 4kyu, imho this should be 5kyu
Wow, it is a tricky kata, but finally my code passed and learned something new.
Happy coding!
This comment has been hidden.
It was really hard for me but after few hours I solved this kata :D
The hardest part was checking to 3x3 grids if they are correct
The first assertFalse of the class used for testing is wrong. After all the modifications done in the first and second child arrays, there is not any value equals zero, so..... the matrix should be considered as a valid board and by consequence, true.
This comment has been hidden.
Check the last two columns, it's been already asked and answered below.
I am stuck on last one, can someone explain why this became Flase [[1, 2, 3, 4, 5, 6, 7, 8, 9] ,[2, 3, 4, 5, 6, 7, 8, 9, 1] ,[3, 4, 5, 6, 7, 8, 9, 1, 2] ,[4, 5, 6, 7, 8, 9, 1, 2, 3] ,[5, 6, 7, 8, 9, 1, 2, 3, 4] ,[6, 7, 8, 9, 1, 2, 3, 4, 5] ,[7, 8, 9, 1, 2, 3, 4, 5, 6] ,[8, 9, 1, 2, 3, 4, 5, 6, 7] ,[9, 1, 2, 3, 4, 5, 6, 7, 8]] it has none
That's why.
Is last test is ok or not?
Last test of which language?
The tests for the Java version are really bad. This lousy, fake, no-good "solution" passes the tests.
I'd like to fix the tests, but they are locked. Only users with > 10k reputation can edit them.
For example, there are no fixed tests with a board in which all columns and rows are correct but the blocks aren't. This solution doesn't correctly check the blocks, and this solution doesn't check them at all, but both pass the tests (well, most of the time – sometimes they fail the random tests).
Can't you make a fork?
This comment has been hidden.
The Rust version doesn't have a test in which all columns, rows and blocks have the sum 45, but are incorrect nonetheless, e.g. because the board is filled with all 5s.
I fixed it. I added a test with a board of all 5s. This of course invalidated many solutions.
The Rust translation has no test with a board in which all columns and rows are correct, but the blocks aren't. For example, this solution doesn't check the blocks, but it passes the tests.
Fixed it. I copied a test from the C translation to the Rust translation. This invalidated several solutions (including mine).
Not everyone knows the rules of Sudoku to understand that there should not be repeating numbers in one block. I would add this to the description
It's already in the description. There is also a link to Wikipedia.
Just missing where this test case is invalid while debugging my code, been staring at it for a bit so thought I'd just ask: [[1, 3, 2, 5, 7, 9, 4, 6, 8] [4, 9, 8, 2, 6, 1, 3, 7, 5] [7, 5, 6, 3, 8, 4, 2, 1, 9] [6, 4, 3, 1, 5, 8, 7, 9, 2] [5, 2, 1, 7, 9, 3, 8, 4, 6] [9, 8, 7, 4, 2, 6, 5, 3, 1] [2, 1, 4, 9, 3, 5, 6, 8, 7] [3, 6, 5, 8, 1, 7, 9, 2, 4] [8, 7, 9, 6, 4, 2, 1, 3, 5]]
Look harder at the last two columns.
Thanks! I saw it now, can't believe I missed that
Can only tell me that is test case 4 correct cause i am trying to solve it for last ew hours
me too im stuck at the last one.
This comment has been hidden.
The blocks are wrong, not a kata issue. Use
Questionlabel when you don't understand something next time.The fact that there is only one test out of 106 that tests for the 3x3 rule certainly has caused a lot of confusion.
Annoyed me enough to cheat.
Cant understand why is this False. I have only this test unexcepted. Looks True for me.
Test number 6
[[1, 2, 3, 4, 5, 6, 7, 8, 9] ,[2, 3, 4, 5, 6, 7, 8, 9, 1] ,[3, 4, 5, 6, 7, 8, 9, 1, 2] ,[4, 5, 6, 7, 8, 9, 1, 2, 3] ,[5, 6, 7, 8, 9, 1, 2, 3, 4] ,[6, 7, 8, 9, 1, 2, 3, 4, 5] ,[7, 8, 9, 1, 2, 3, 4, 5, 6] ,[8, 9, 1, 2, 3, 4, 5, 6, 7] ,[9, 1, 2, 3, 4, 5, 6, 7, 8]]), False);
The blocks are wrong, not a kata issue.
Im stuck on this too, i really get more and more confuse, there aren't number that dup.
The 3x3 block should not repeat numbers also.
I want to use flat, but Node version < 11
This is my first 4kyu kata. I solved it. Thank you so much)
congrats!
Much more tests are necessary !! Lots of wrong solutions are being accepted !!
This feels like it belongs as a 6 kyu kata instead of 4. And also the tests aren't rigorous enough. My solution actually passed before I even checked the horizontal rows.
Still, fun.
If you found a bug in the translation of a certain language (and you're certain about it), please raise an
Issuedescribing the problem (make sure to mention which language is affected)that's JS
oh good, so it's someone else's problem.
New Rust translation, includes random tests.
Approved.
I enjoyed this kata, but a lot of these issues seem to be derived from the "subsquares" category. In sudoku, there are 3x3 grids (or squares) for each square that also must not have any of the same numbers in that 3x3 grid. From what I've read, the tests don't check every square, so I would change that.
I would also recommend updating the kata description just so there are no further headaches from issues being raised from a misunderstanding (I understand that there is a wikipedia article linked to inform others about sudoku, but realistically not that many of us are going to read that). It'll just makes this whole message board a lot simplier imo.
Very poor Kata. My solution ignores '0' entries (which is forbidden) and passes !
This is not an issue moreso redundancy in the Kata description. It is possible to divide the board into rows, columns, and subsquares and check that they all have each digit from 1-9 while ignoring any other ints. Not a broken Kata but probably overrated in difficulty.
There are several issues raised about that.
all tests done in this kata only test the first block, not all the 9 blocks; please add more cases to the test so it checks other blocks
for one of my submitted solutions, this case returns true, and it should return false
[ [2, 3, 1, 5, 6, 4, 8, 9, 7],
[4, 5, 6, 7, 8, 9, 1, 2, 3],
[8, 9, 7, 2, 3, 1, 5, 6, 4],
[3, 1, 2, 6, 4, 5, 9, 7, 8],
[1, 2, 3, 4, 5, 6, 7, 8, 9],
[5, 6, 4, 8, 9, 7, 2, 3, 1],
[6, 4, 5, 9, 7, 8, 3, 1, 2],
[7, 8, 9, 1, 2, 3, 4, 5, 6],
[9, 7, 8, 3, 1, 2, 6, 4, 5]]
This is actually an issue, and there are several already raised about tests being insufficient in most (if not all languages). Your suggestion is not bad per se, but it's part of a much larger issue in this kata that is already pointed out, I would suggest you to close it (we could open tens of other similar suggestions, without fixing the root of the problem).
This comment has been hidden.
It says there that your code is returning false.
It is telling me when I attempt that this should return false: validSolution([[1, 2, 3, 4, 5, 6, 7, 8, 9], [2, 3, 1, 5, 6, 4, 8, 9, 7], [3, 1, 2, 6, 4, 5, 9, 7, 8], [4, 5, 6, 7, 8, 9, 1, 2, 3], [5, 6, 4, 8, 9, 7, 2, 3, 1], [6, 4, 5, 9, 7, 8, 3, 1, 2], [7, 8, 9, 1, 2, 3, 4, 5, 6], [8, 9, 7, 2, 3, 1, 5, 6, 4], [9, 7, 8, 3, 1, 2, 6, 4, 5]])
Clearly it should return true. Very frustrating
Clearly, read the description again, the blocks are wrong.
No random tests in Clojure
No random tests in Scala
Fixed
This comment has been hidden.
Please, someone check if there are random tests in Clojure, Prolog, Ruby, and Scala. I don't code in these languages, so I am unable to check without forfeiting.
Ruby,Scala: no random tests The others I haven't solved
This comment has been hidden.
Thanks guys.
@akar-0 nice trick, but even when I see test cases in Prolog, I still hardly understand what it does lmao.
Yes, can be hard sometimes, but it was just in case you didn't know it (it took me more than one year before realizing it).
No random tests in Python
No random tests in PHP
No random tests in JavaScript
No random tests in Go
No random tests in C#
No random tests in C++
No random tests in CoffeScript
No random tests in C
How can I view the "attempt" tests? I want to see the 6th test to see what I missed.
https://docs.codewars.com/training/troubleshooting/#works-but-no
Hi, why this case test should be false?
Good kata, thanks!
3x3 boxes.
(you should read the rules of sudoku, if you don't know them. That could help... ;o )
Hi, in final tests I've got valid board with invalid test expectation (false).
1 2 3 4 5 6 7 8 9 2 3 1 5 6 4 8 9 7 3 1 2 6 4 5 9 7 8 4 5 6 7 8 9 1 2 3 5 6 4 8 9 7 2 3 1 6 4 5 9 7 8 3 1 2 7 8 9 1 2 3 4 5 6 8 9 7 2 3 1 5 6 4 9 7 8 3 1 2 6 4 5
Please read this: https://docs.codewars.com/references/markdown/#code-block about how to post without losing formatting.
The blocks in that sudoku are wrong, the expected value (false) is ok. Not a kata issue.
The last example test expects false, but is a valid solution. If I change the example test to assertTrue, so that i can submit my code and acess the random tests, my code passes all the random tests. absolutley no reason the last grid should return false!
5 3 4 6 7 8 9 1 2
6 7 2 1 9 5 3 4 8
1 9 8 3 4 2 5 6 7
8 5 9 7 6 1 4 2 3
4 2 6 8 0 3 7 9 1
7 1 3 9 2 4 8 5 6
9 6 1 5 3 7 2 8 4
2 8 7 4 1 9 6 3 5
3 4 5 2 8 6 1 7 9
There is a 0 in the middle, not a kata issue.
Oh my bad i thought the instruction said if it contains more than one zero it is invalid.
i see 0 in 5 raw
Test/Attempt is not working: Expected 'false' on input of [ [ 1, 2, 3, 4, 5, 6, 7, 8, 9 ], [ 2, 3, 1, 5, 6, 4, 8, 9, 7 ], [ 3, 1, 2, 6, 4, 5, 9, 7, 8 ], [ 4, 5, 6, 7, 8, 9, 1, 2, 3 ], [ 5, 6, 4, 8, 9, 7, 2, 3, 1 ], [ 6, 4, 5, 9, 7, 8, 3, 1, 2 ], [ 7, 8, 9, 1, 2, 3, 4, 5, 6 ], [ 8, 9, 7, 2, 3, 1, 5, 6, 4 ], [ 9, 7, 8, 3, 1, 2, 6, 4, 5 ] ] but it is true!
No, it's not true. I just looked at bottom left 3x3 square, and it only contains 3 numbers - 7, 8, 9, when it should contain 9 distinct numbers.
Please look at the number of completions and read other posts before rushing to file a bogus kata issue.
Very good kata, loved it! Thanks :)
Test needs fix: Columns are not checked.
Test/Attempt is not working:
Expected 'true' on input of
: expected false to equal trueRead this: https://www.codewars.com/kata/529bf0e9bdf7657179000008/discuss#5e5d7cd837738b00289583e9 That's not the input of the test your code fails.
Hi, guys!
Can someone tell me, why this text [1, 3, 2, 5, 7, 9, 4, 6, 8] [4, 9, 8, 2, 6, 1, 3, 7, 5] [7, 5, 6, 3, 8, 4, 2, 1, 9] [6, 4, 3, 1, 5, 8, 7, 9, 2] [5, 2, 1, 7, 9, 3, 8, 4, 6] [9, 8, 7, 4, 2, 6, 5, 3, 1] [2, 1, 4, 9, 3, 5, 6, 8, 7] [3, 6, 5, 8, 1, 7, 9, 2, 4] [8, 7, 9, 6, 4, 2, 1, 3, 5] should returns False instead of True?
Look at 7th column.
Can you told what exactly incorrect in 7th column, because I still don't know why this text should returns False?
Damn... Don't you see the 7th column is not right? Do you really need me to detail which number is duplicated, and which number is missing?
Sorry, akar-0, i'm alredy saw my fault. Thanks a lot for helping!)
Sorry, I meants the 8th.
Haskell translation
Kata retired.
This comment has been hidden.
Duplicate issue.
I think this kata is too easy for 4kyu.
You can't change the rating of already rated katas
Yeah... I know. Just a simple suggestion that it was too easy.
I think the tricky part was to check each of those 3X3 possible boxes.
This comment has been hidden.
From a glance: the last column has two 5s. In any case, this is not a kata issue. Your code is buggy.
I focused on block.thank u so much
last text seems innacurate... [[1, 2, 3, 4, 5, 6, 7, 8, 9], [2, 3, 4, 5, 6, 7, 8, 9, 1], [3, 4, 5, 6, 7, 8, 9, 1, 2], [4, 5, 6, 7, 8, 9, 1, 2, 3], [5, 6, 7, 8, 9, 1, 2, 3, 4], [6, 7, 8, 9, 1, 2, 3, 4, 5], [7, 8, 9, 1, 2, 3, 4, 5, 6], [8, 9, 1, 2, 3, 4, 5, 6, 7], [9, 1, 2, 3, 4, 5, 6, 7, 8]] is a valid solution no?
It only is if you are counting only rows and columns. However, sudoku also has squares(nine squares in total), and this test has valid rows and columns, but not valid squares.
Ah lol, I don't know the game well, thanks for the heads up
Last test should be fixed
Nope!! it's the correct. all 3x3 grids must have digits from 1 to 9
This comment has been hidden.
Nah, there's no timeouts for this solution, in line 15 the inline for loops are executed from left to right, meaning that first the program will go through
pairs, and then will go throughsquare_rangesviapairs. The problem is, we try to go throughpairswithout knowing what is this variable (that will be on the next loop), thus an error.Try to swap these loops, so first you get
pairs in square_ranges, and thenpair in pairs.P.S. You shouldn't make a for loop for
pvariable; work exactly with it, not withs. I mean,pis pair of numbers, therefore, you can access them viap[0]andp[1], right?This comment has been hidden.
This comment has been hidden.
In c my solution was accepted, even if i checked only for blocks correctness,
{{1,2,3,1,2,3,1,2,3}, {4,5,6,4,5,6,4,5,6}, {7,8,9,7,8,9,7,8,9}, {1,2,3,1,2,3,1,2,3}, {4,5,6,4,5,6,4,5,6}, {7,8,9,7,8,9,7,8,9}, {1,2,3,1,2,3,1,2,3}, {4,5,6,4,5,6,4,5,6}, {7,8,9,7,8,9,7,8,9}}
should return false but my code returns true, in spite of this I passed all the tests. please add check for row/column number repetition
There are already open issues about incomplete tests, there's no point in raising new ones.
Look at the last column of the first screenshot (btw, post them as formatted text ordered, not like that, it's hard to read).
In the second one, the blocks are wrong.
(Nvm got it, thx!)
This comment has been hidden.
This is not a kata issue. A question maybe.
You should check the each 3x3 square too!
Thank you, xDranik, for this amazing kata😊
This comment has been hidden.
you cannot have zeroes in a valid/solved grid. See
sudoku[4][4] = 0edit: the tests are actually written like this, or is that you doing some tries?? xs
Oh, I thought 1 zero is fine. Misread the instruction, thank you!
why is this not a valid slution? [[1, 3, 2, 5, 7, 9, 4, 6, 8], [4, 9, 8, 2, 6, 1, 3, 7, 5], [7, 5, 6, 3, 8, 4, 2, 1, 9], [6, 4, 3, 1, 5, 8, 7, 9, 2], [5, 2, 1, 7, 9, 3, 8, 4, 6], [9, 8, 7, 4, 2, 6, 5, 3, 1], [2, 1, 4, 9, 3, 5, 6, 8, 7], [3, 6, 5, 8, 1, 7, 9, 2, 4], [8, 7, 9, 6, 4, 2, 1, 3, 5]]
i am getting "True should equal False" for above solution..
Check the 2nd last column. There's 2
3s in there.This comment has been hidden.
board=[[1,2,3,4,5,6,7,8,9], [2,3,1,6,4,5,8,9,7], [3,1,2,5,6,4,9,7,8], [4,5,6,7,8,9,1,2,3], [5,6,4,8,9,7,3,1,2], [6,4,5,9,7,8,2,3,1], [7,9,8,1,3,2,5,4,6], [8,7,9,2,1,3,4,6,5], [9,8,7,3,2,1,6,5,4]] give it a try
"and each of the nine 3x3 sub-grids (also known as blocks) contain all of the digits from 1 to 9."
[1,2,3,2,3,1,3,1,2] This is not Sudoku
perfect, thank you very much, I was able to solve it, I did not realize that I was missing that
I passed all attempts except the fourth :(, does anyone know what this test is? I would like to know where is my problem.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
The problem is you're mutating the input.
Expected 'false' on input of
: expected true to equal false ??????????????????“and each of the nine 3x3 sub-grids (also known as blocks) contain all of the digits from 1 to 9.”
i forgot that the 3 by 3 grids existed
[1, 2, 3, 4, 5, 6, 7, 8, 9] [2, 3, 4, 5, 6, 7, 8, 9, 1] [3, 4, 5, 6, 7, 8, 9, 1, 2] [4, 5, 6, 7, 8, 9, 1, 2, 3] [5, 6, 7, 8, 9, 1, 2, 3, 4] [6, 7, 8, 9, 1, 2, 3, 4, 5] [7, 8, 9, 1, 2, 3, 4, 5, 6] [8, 9, 1, 2, 3, 4, 5, 6, 7] [9, 1, 2, 3, 4, 5, 6, 7, 8]
Why is this being logged as "True should equal False" - it's a valid solution i.e True? Thx
No, it's not, read the posts below (like this one) or Sudoku's rules again to know why.
I didn't see the response in the earlier post but since you confirm it's correct, another look shows the sub 3x3 grid is the problem. thx.
This comment has been hidden.
No, it's not valid. Read Sudoku rules again.
input: [1, 3, 2, 5, 7, 9, 4, 6, 8] [4, 9, 8, 2, 6, 0, 3, 7, 5] [7, 0, 6, 3, 8, 0, 2, 1, 9] [6, 4, 3, 1, 5, 0, 7, 9, 2] [5, 2, 1, 7, 9, 0, 8, 4, 6] [9, 8, 0, 4, 2, 6, 5, 3, 1] [2, 1, 4, 9, 3, 5, 6, 8, 7] [3, 6, 0, 8, 1, 7, 9, 2, 4] [8, 7, 0, 6, 4, 2, 1, 3, 5] Expected result = False Returns True
my code on the site returns True, but on my code editor returns False, is it bugged?
Try looking at this https://docs.codewars.com/training/troubleshooting/#works-but-no
This comment has been hidden.
should_pass_all_tests Log 5 6 1 8 4 7 9 2 3 3 7 9 5 2 1 6 8 4 4 2 8 9 6 3 1 7 5 6 1 3 7 8 9 5 4 2 7 9 4 6 5 2 3 1 8 8 5 2 1 3 4 7 9 6 9 3 5 4 7 8 2 6 1 1 4 6 2 9 5 8 3 7 2 8 7 3 1 6 4 5 9 //-- 8 7 1 3 6 4 9 5 2 2 3 9 1 5 8 4 6 7 6 5 4 7 9 2 8 1 3 3 8 2 5 1 9 7 4 6 4 1 6 8 7 3 5 2 9 7 9 5 4 2 6 1 3 8 5 6 8 2 4 7 3 9 1 9 4 7 6 3 1 2 8 5 1 2 3 9 8 5 6 7 4 //-- 1 2 3 4 5 6 7 8 9 2 3 1 5 6 4 8 9 7 3 1 2 6 4 5 9 7 8 4 5 6 7 8 9 1 2 3 5 6 4 8 9 7 2 3 1 6 4 5 9 7 8 3 1 2 7 8 9 1 2 3 4 5 6 8 9 7 2 3 1 5 6 4 9 7 8 3 1 2 6 4 5 //-- Expected: false Actual: true
Should the correct answer be the truth?
No.
Do you see all numbers from 1 to 9 there?
This comment has been hidden.
This comment has been hidden.
All the rules are explained, and the link is there to let you read the rules fully.
About 3.
You should return false when a 0 is on the board, yes. No other rule needed.
fun, but maybe too easy for 4kyu, some 6kyu seems harder than that ?
weird how you got dislikes. i even had 7kyu challenges that are harder than this one. 6kyu - 7kyu sounds more accurate. note even sure why some people struggle with this one because its really straight forward (no mathematical trick, no algorithmic trick, no performance issues). maybe some people dont know how to play sudokus and have a hard time understanding this problem.
This kata is almost exact duplicate of this one: https://www.codewars.com/kata/53db96041f1a7d32dc0004d2/python
This comment has been hidden.
same issue in C++
This comment has been hidden.
it's not wrong
look at the extreme right column
Oh, Thank you, @Siddharth114! I have been saw that <3
I'm failing one of the tests, but I cant see why it failed. how can I see the failing test input?
Printing the input: https://docs.codewars.com/training/troubleshooting/#print-input
Great this was very helpful
BTW, why this metrix should fail by the test? [1, 2, 3, 4, 5, 6, 7, 8, 9], [2, 3, 4, 5, 6, 7, 8, 9, 1], [3, 4, 5, 6, 7, 8, 9, 1, 2], [4, 5, 6, 7, 8, 9, 1, 2, 3], [5, 6, 7, 8, 9, 1, 2, 3, 4], [6, 7, 8, 9, 1, 2, 3, 4, 5], [7, 8, 9, 1, 2, 3, 4, 5, 6], [8, 9, 1, 2, 3, 4, 5, 6, 7], [9, 1, 2, 3, 4, 5, 6, 7, 8]
Thanks, Guy
Because of this:
Yep, see it now the 3X3 grids also need to be alligned with 1-9 digits.
Thanks, Guy
Am I the only one who spent lots of time debugging their solution, only to finally notice that the requirements omit the standard Sudoku requirement concerning the diagonals also being complete sets?
Because there is no such rule. If you refer to the central column/row, well, all of them should be a complete set, I don't see why that should be explained as separate items.
Wow. I just checked wikipedia, and you're absolutely right, it's under the 'additional constraints' section.
Every newspaper sudoku I've ever solved had that rule... Amazing.
This comment has been hidden.
there's no error, your algorithm fails to pass one test
This comment has been hidden.
KOTLIN TRANSLATION
Please review and approve.
Hi,
THERE IS NO NEED TO SHOUT LIKE THAT...
;)
cheers
Wasn't mean as shout, anyway I cannot edit it to lower case anymore, sorry.
Why my stupid solution still pass with all test cases ? :v.
I think there shoud be a test like the
test1of this fork. With that test, my solution will be wrong. And I think there mustn't have any solution like this :v.easy kata i think this one should be 5 kata
Java improvement
Can I approve blind?
Approved by someone
Really forces you to think in terms of a coordinate system and how to call the desired values with respect to coordinates
in my function is board only array of ints not array of arrays of ints, why?
this is a 2D array. so its type is int anyways.
So, i must validate only one row?
In C++, the solution function prototype is
bool validSolution(unsigned int board[9][9]), and the input is a 2D array. Did you change the original setup?no
I tried to implement a clean java solution -> https://www.codewars.com/kata/reviews/599ffcffc91db961910009fb/groups/61f4b260fb076500017a03e5 Would be great if you give your feedback =)
pls add random tests
Duplicate issue, closing.
True should equal False? This has to be the most straight forward True sudoku
I'd suggest you actually read the sudoku rules, before saying something like that... 'x)
This is
False. Re-read the part in the description aboutsub-grids (also known as blocks).My bad.
Hi, can someone explain me why it expects this to be 'true'? And what does that 'pre' mean? And why the input isn't an array? My function seems to work on other tests. Thanks a lot
Expected 'true' on input of
: expected false to equal trueYou're misreading the logs, that test expects false. Read this: https://docs.codewars.com/training/troubleshooting/#print-input
Ok, thanks. Edit: I wrote that same input as an array of arrays:
console.log(validSolution([[1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9], [1, 2, 3, 4, 5, 6, 7, 8, 9]])) and the result is "false". Obviously if I do this:
console.log(1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9 1 2 3 4 5 6 7 8 9) it gives error. Do someone have an idea?
Good day. The order from 1 to 9 should be horizontal and vertical at the same time. This rule is the main idea of the game. If you look on the first column of your "table", you will see, that all values are equal to '1', instead of being in order from '1' to '9'
Hi, thanks for the answer but I don't think you got the problem (or maybe I don't get your answer). I know that table isn't regular and my program recognizes it too, but only if I reorganise the input of the test as an array of arrays, as it should be. I'm thinking the problem might be that that input given by the test isn't an array as the others, but something else. I can't understand what type of data is that: it has spaces, so it isn't a number, but it hasn't the quotes, then it isn't a String.
tito.plauto - did you find the solution of this? Because I currently have the same problem. The strange thing that when I'm copying this matrix and trying to test it it works, but it fails during the attempts
No, I'm sorry, I just gave up after infinite tries
The input is always an array of arrays, and you can see that printing the input.
test Expected 'false' on input of
: expected true to equal falseThe test is fine.
Nice kata!!! If your code doesn't pass all of the tests, read task more clearly. Don't be in hurry, think twice before writing anything :)
kata hint != kata suggestion
If
Boards containing one or more zeroes are considered to be invalid solutions.then why does it expect true when I return false on a row containing[0, 1, 2, 3, 4, 6, 7, 8, 9]?Language was Javascript.
That test expects false. Make sure you're reading the log right.
how are the little squares supposed to contain numbers 1-9? please help me understand :,(
See the top-right image in the Wikipedia link, there is a solved sudoku there.
This comment has been hidden.
Same, after one month from your comment. I made the code for the grids and wanted to test if I get any errors, and to my surprice I passed all the tests before making the code for the rows and the cols.
What language ( of the twelve ) ?
That's javascript. Yes I know you know, but OP didn't answer so...
This comment has been hidden.
https://www.codewars.com/kata/529bf0e9bdf7657179000008/discuss#6173f4e4ec726e0026bc95b5
You can't have the same number in a 3 by 3 sector
This comment has been hidden.
The lack of random tests is a known issue (there are open issues below). Please use spoiler flag next time. Closing as a duplicate issue.
At first glance it seems easier than it really is). Nice kata.
What is the last test i feel like ive tried everything but it keeps failing at the last one
Most probably your code simply isn't valid. Tests only show you one test failing because they stop after that. Anyway, it's impossible to help you concretely, without even knowing the language you're using, and we have no idea of what your code is. Have a look there: https://docs.codewars.com/training/troubleshooting/
would there be a way i could share my code privately?i'm using python btw
Yes, you can post your code, with a spoiler flag (just tick the box
Mark as having spoiler contentabove the markReplay/Cancel). Also please use markdown tags to format your code, or it's very discomfortable to handle and read, in Python especially. See there: https://docs.codewars.com/references/markdown/#code-blockThis comment has been hidden.
Your solution seems to return invalid asnwer for following board:
Expected answer is
False, but your solution seems to returnTrue.Yes thank you very much i will try fixing it!
You can easily print the input in Python, just use
print(board)and you'll see where your code fails.This comment has been hidden.
I submitted my solution for Java and the moreRandomTests failed. I manually checked and my code is correct, it is the expected solution that is wrong. This one expects false -
4 5 6 8 9 7 1 2 3 7 8 9 2 3 1 4 5 6 1 2 3 5 6 4 7 8 9 8 9 1 3 4 2 5 6 7 2 3 4 6 7 5 8 9 1 5 6 7 9 1 8 2 3 4 6 7 8 1 2 9 3 4 5 9 1 2 4 5 3 6 7 8 3 4 5 7 8 6 9 1 2
I guess the test is done randomly because after testing it again, I fail on a different array each time that incorrectly expects false - 4 5 9 3 7 2 8 6 1 2 3 7 1 5 9 6 4 8 9 1 5 8 3 7 4 2 6 3 4 8 2 6 1 7 5 9 1 2 6 9 4 8 5 3 7 5 6 1 4 8 3 9 7 2 8 9 4 7 2 6 3 1 5 7 8 3 6 1 5 2 9 4 6 7 2 5 9 4 1 8 3
and
3 8 7 1 4 9 2 5 6 6 2 1 4 7 3 5 8 9 9 5 4 7 1 6 8 2 3 5 1 9 3 6 2 4 7 8 2 7 6 9 3 8 1 4 5 4 9 8 2 5 1 3 6 7 7 3 2 5 8 4 6 9 1 1 6 5 8 2 7 9 3 4 8 4 3 6 9 5 7 1 2
Please see this paragraph and make sure you are readign logs correctly: https://docs.codewars.com/training/troubleshooting#print-input
If you are 100% sure your solution is correct, post your code so we could diagnose your problem.
This comment has been hidden.
Test cases your solution fails correctly expect
false. Both test casees you presented have invalid 3x3 sub-grids.why must test6 be false when there are all digits between 1 and 9 ? it gives me this message: "The expression (validSolution(test6)) == (0) is false." but it should be true and not false {[1, 2, 3, 4, 5, 6, 7, 8, 9], [2, 3, 1, 5, 6, 4, 8, 9, 7], [3, 1, 2, 6, 4, 5, 9, 7, 8], [4, 5, 6, 7, 8, 9, 1, 2, 3], [5, 6, 4, 8, 9, 7, 2, 3, 1], [6, 4, 5, 9, 7, 8, 3, 1, 2], [7, 8, 9, 1, 2, 3, 4, 5, 6], [8, 9, 7, 2, 3, 1, 5, 6, 4], [9, 7, 8, 3, 1, 2, 6, 4, 5]}
(i do it in C language)
Not a kata issue.
been stuck for an hour and just read this lol
the solution of the author of this kata generates False whereas it should be equal to True
please check this input and give me your feedback
I generated a list(flatten) of values for each block
I generated a set of values for each block
Don't open another issue about the same, read the answers to your previous post. The blocks are fine, the last two columns, aren't.
thank you for your response
No problem.
I solved this kata
please, check my solution in the link
Hi gues, solution this kata do not work correctly
this input return False
review your solution for this input
Check the last two columns, not a kata issue.
I extracted and generated the boxes to apply and it works very well, please show me on this generation the error
I generated a set of values for each block
Two 5 in the last column and no 3...
I don't see two 5 in the last column and no 3, try to extract the blocks that do not work in this example
thank you for your response,
Hi, guys. I need help on completing this kata, my solution works perfectly on fixed test, but when attempting the solution it gives this error, there seems to be cause by the pre tag appearing in the test result.
I'm attepting this kata using javascript
Expected 'false' on input of
: expected true to equal falseI already log the board array and there's nothing wrong with the array, here is the log
[ [ 1, 2, 3, 4, 5, 6, 7, 8, 9 ], [ 2, 3, 1, 5, 6, 4, 8, 9, 7 ], [ 3, 1, 2, 6, 4, 5, 9, 7, 8 ], [ 4, 5, 6, 7, 8, 9, 1, 2, 3 ], [ 5, 6, 4, 8, 9, 7, 2, 3, 1 ], [ 6, 4, 5, 9, 7, 8, 3, 1, 2 ], [ 7, 8, 9, 1, 2, 3, 4, 5, 6 ], [ 8, 9, 7, 2, 3, 1, 5, 6, 4 ], [ 9, 7, 8, 3, 1, 2, 6, 4, 5 ] ]
falseis ok, not a kata issue.So if there's nothing wrong with the array then what is the issue?
The array isn't a valid sudoku, your code is returning
true, so the problem is in your code.Do you see all of the digits from 1 to 9 there?
but all of the arrays have 1 to 9 as you can see from the log
(If that's directed at me, then what I meant is that a problem is not described in this
Issue, it's stated that the input is good, leaving no other problems)no, not all, @Chrono79 pointed out one that doesn't
I think the fifth test in the attempt in JavaScript should be valid:
And it is, make sure you're not reading the logs wrong. Also note the tests are shuffled every time, so that test won't always be the fifth.
Thank you, you are right. Now the problem is that my code returns true only when I test it myself (clicking on the test button), but false when click on attempt.
Read this: https://docs.codewars.com/training/troubleshooting/ see if it helps.
Sorry, I forgot to mention that I also copied the matrix that fails in the attempt, and pasted it in the section for my own tests. The same code doesn't fail the same test when I run my own tests, rather than the attempt.
Are you using some global var?
No I am not use any global variable, but I found the bug. In the tests for the attempt the board has 9 rows, and each of them is an array with 9 elements and a 10th property called 'shuffle' that contains a function. Running this code:
for(const i in board) console.log(i, board[0][i])I could see this printed out:Thank you for your help.
Boards containing one or more zeroes are considered to be invalid solutions. =)
[492856913, 176423459, 385791726, 753284261, 941635387, 628179045, 453678900, 519348172, 234567898]Expected: true Actual: false
Mention the language when reporting an issue, please.
;C++
With my PHP solution, when I click on the "Test" button, everything passes, I included more tests just to be sure. But when I click in "Attempt" not even one test passes. I checked, because the first check I do in my code is check for zeroes, and yes, when clicking on "Test" everything works, if there is a zero in the matrix, the function will return false, but when "Attempt" if the test array has zeroes the interpreter or whatever it is, will ignore the conditionals and return true every time, if I just cheat and return false, the test will say the expected value is true, so, seems like that test is completely broken.
Hi,
no, with 500+ other completions in PHP, the tests aren't broken. When you click "TEST", your solution is run against more tests than the ones you see in the sample tests part. And those tests are randomized. Meaning your only problem is that your code doesn't handle some specific case you didn't think about. Just print the inputs to the console, then debug your code.
Cheers
PS:
I did printed the input on the console, and even when I think my solution is complete, I get that's what tests are for and I might overlooked something, but I'm pretty sure something is not working well, is it possible that something has changed in the tests that broke things?
Not possible, since any such change would invalidate current accepted solutions, and currently no solutions have been invalidated.
[ [1, 3, 2, 5, 7, 9, 4, 6, 8], [4, 9, 8, 2, 6, 1, 3, 7, 5], [7, 5, 6, 3, 8, 4, 2, 1, 9], [6, 4, 3, 1, 5, 8, 7, 9, 2], [5, 2, 1, 7, 9, 3, 8, 4, 6], [9, 8, 7, 4, 2, 6, 5, 3, 1], [2, 1, 4, 9, 3, 5, 6, 8, 7], [3, 6, 5, 8, 1, 7, 9, 2, 4], [8, 7, 9, 6, 4, 2, 1, 3, 5] ]
True should equal False
But why i ckecked with my eyes, bruh!
Check your eyes, bruh! And also the last 2 columns ;)
good one, i forgot to check along the axis i got it now
This test 6 i think should be true...but is false, dont see why
True should equal False
board:[[1, 2, 3, 4, 5, 6, 7, 8, 9], [2, 3, 4, 5, 6, 7, 8, 9, 1], [3, 4, 5, 6, 7, 8, 9, 1, 2], [4, 5, 6, 7, 8, 9, 1, 2, 3], [5, 6, 7, 8, 9, 1, 2, 3, 4], [6, 7, 8, 9, 1, 2, 3, 4, 5], [7, 8, 9, 1, 2, 3, 4, 5, 6], [8, 9, 1, 2, 3, 4, 5, 6, 7], [9, 1, 2, 3, 4, 5, 6, 7, 8]]
Thanks I totally miss this point as well, as ther are no grid lines like suduko 😇
Why this is not the valid sudoko?
What else is left, test 4 is not working.
No, check the last column again. And maybe next time, paste the sudoku.
Yes checked, there was some issue with 8 and 9 column, I was able to solve it. Mine solution was not very good but it works, so no issue, you can check and rate my code if you want, any suggestion will be appreciated.
C++ version of kata should use more modern and familiar type for passing board to function. Passing fixed arrays is very unusual to C++, and if we taking into account that it is actually a pointer to fixed array it becomes even more non-obvious, unsafe and inconvenient to work with. I think there is should be some container from STL, such as
std::vector< std::vector< unsigned int > >orstd::array< std::array< unsigned int, 3 >, 3 >.This problem is for 6 kyu, but i can earn more honor HAHAHA
This comment has been hidden.
The tests are insufficient and will accept invalid sudokus. Check my solution for clarification.
This is well known issue for this kata that has been reported several times, see the existing pendent issues in Discourse. There is no need to open more.
That's good to know for the future. Where do I check pending issues? All I see are comments tagged "issues".
Just above the last comment in Discourse, you can choose
All - Issues - Questions - Suggestions. Pendent issues have theissuetag aside in bright red while it is greyed on old issues. It's not always easy to navigate through all old and newer issues when they are numerous like here, but it's all we have. PS: Just like you I raised a duplicated issue about this kata 8 months ago ;)This comment has been hidden.
.
@IceTornadax input presented by you is not a valid sudoku board. From the description:
@hobovsky Ah understood thanks
.
I would like to point out that 6 month to eight ago i reported the same issue only to have it immediately closed by someone being a troll. The actions of that person made it impossible for me to get advice from others or report things like this bug (they kept closing out all my bug reports) and its the reason i moved to other coding platforms than this to code.
This comment has been hidden.
That's your code's problem, not a kata issue.
[1, 3, 2, 5, 7, 9, 4, 6, 8] [4, 9, 8, 2, 6, 1, 3, 7, 5] [7, 5, 6, 3, 8, 4, 2, 1, 9] [6, 4, 3, 1, 5, 8, 7, 9, 2] [5, 2, 1, 7, 9, 3, 8, 4, 6] [9, 8, 7, 4, 2, 6, 5, 3, 1] [2, 1, 4, 9, 3, 5, 6, 8, 7] [3, 6, 5, 8, 1, 7, 9, 2, 4] [8, 7, 9, 6, 4, 2, 1, 3, 5] True should equal False
Columns 8 and 9 have duplicate values (3 and 5 respectively). When I run in Virtual Studio (Python version 3.9) I get False. When run in codewars it comes back as True. The data set I've attached above is directly above the error "True should equal False. Is anyone able to assit? Kata attempted in Python. Thanks
Hi. There must be a problem with your code ; tests expect False in this case, I've just run my solution and it works fine, this kata has been completed more than a 10000 times... You can post your code with a spoiler flag to get further help.
There are only 6 tests in Python (?)
During the attempt, test 4 returns True when it should return False, if I test the case in pycharm it works and returns False, the sudoku board contains 0 and the first for loop in my code checks for a 0 row1 = board[0] row2 = board[1] row3 = board[2] row4 = board[3] row5 = board[4] row6 = board[5] row7 = board[6] row8 = board[7] row9 = board[8] for row in rows: if 0 in row: return False Why does this not work in the codewars interpreter?
There're no
0's in the 4th test. You're misinterpreting the logs, not an issue.I took my own solution from a 5 kyu kata "Did I Finish my Sudoku?" and passed without any modifications. This kata should be retired.
I agree. The only difference is, for this one "0" is specified as needing to return false. Otherwise, it is the exact same.
Interesting
There seems to be lack of tests judging by my solution.
This comment has been hidden.
Tests are not enough.
This comment has been hidden.
I have a very rare edge case that sows up in the "more random tests" section and breaks my algorith. How can I find out what this edge case it because I have tried a lot of cases on my own IDE and am having no incorrect results. I cannot read the stack trace but does anyone know how I can find the paramter that caused my code to fail?
You did not specify your language, but I'm reasonably sure that every language has some method of printing or logging text to the console/stdout. Do this with your input at the top of your solution to see which input caused the error.
Ruby 3.0 should be enabled, see this to learn how to do it
Kata retired.
it's working but i have a problem in the test6 idk why can i get the sudoku of the test 6 to see where is the problem in my solution ?
My javascript solution works in my IDE, but in codewars, when I use the following line in my solution:
columns[j].push(board[i][j]);
it gives me "TypeError: columns[j].push is not a function". However the exact same code works in my IDE, and I know this should work in javascript. Maybe this is not a kata-specific issue but I need to contact codewars directly about their javascript implementation?
Also to note: I do NOT get this error when I only press "Test" in codewars (and my solution does pass those tests). It is only when I press "Attempt" that this error occurs, even though the code has not changed.
Does your code contain
for ... in?It does! But as far as I understand, (for...in something) is just a shorter way of writing for (let i = 0; i < something.length; i++) where something an iterable object? Would the code work if I wrote it the longer way?
Try it.
Huh. That worked, but I don't really understand why. I had to replace every instance of (for i in board) with (let i = 0; i < 9, i++). Why was this necessary, especially considering that I didn't need to make this change in my IDE? Is it an idiosyncrasy of codewars?
Either way, thanks!
Check this snippet:
I have a test: [[1, 3, 2, 5, 7, 9, 4, 6, 8], [4, 9, 8, 2, 6, 0, 3, 7, 5], [7, 0, 6, 3, 8, 0, 2, 1, 9], [6, 4, 3, 1, 5, 0, 7, 9, 2], [5, 2, 1, 7, 9, 0, 8, 4, 6], [9, 8, 0, 4, 2, 6, 5, 3, 1], [2, 1, 4, 9, 3, 5, 6, 8, 7], [3, 6, 0, 8, 1, 7, 9, 2, 4], [8, 7, 0, 6, 4, 2, 1, 3, 5]]
and CodeWars think it's True (uncorrect), but on my compiler return False(correct). How it possible?? I resseted task, but it isn't work
Please see here: https://docs.codewars.com/training/troubleshooting/#print-input and make sure you are not misinterpreting the logs.
This comment has been hidden.
This comment has been hidden.
I am not even sure my solution is correct because theres only one test which is false because of an box mistake.
Sudoku keeps the mind spry.
i hate that kata. spend 1.5 hours for that (
how lucky, I spend like 4 hours in this
Weird that there exist almost the same kata (Validate Sudoku with size
NxN), but what is even more weird is that they both have the same rank 🤷♂️This comment has been hidden.
[1, 3, 2, 5, 7, 9, 4, 6, 8] [4, 9, 8, 2, 6, 1, 3, 7, 5] [7, 5, 6, 3, 8, 4, 2, 1, 9] [6, 4, 3, 1, 5, 8, 7, 9, 2] [5, 2, 1, 7, 9, 3, 8, 4, 6] [9, 8, 7, 4, 2, 6, 5, 3, 1] [2, 1, 4, 9, 3, 5, 6, 8, 7] [3, 6, 5, 8, 1, 7, 9, 2, 4] [8, 7, 9, 6, 4, 2, 1, 3, 5]
I think this test is supposed to be True, but the answer is False at the moment.
The test is ok, check the two last columns.
Thank you very much, sir!
My solution on Java is the shortest and clear enough :)
This comment has been hidden.
I have the same problem
This comment has been hidden.
This comment has been hidden.
There are several open issues about the lack of random tests, there is no need to open more. Thanks.
If you want you can fork the Python version to add random tests. Note the random tests should ideally generate both valid and invalid boards 50% and 50%.
I did it the brute force way. Not proud, but at least my code can be read by a monkey.
You will like https://www.codewars.com/kata/52bb6539a4cf1b12d90005b7 this kata then :) // It's battleship field validator. Tried to find your solution, but unsuccessfully.
Test Failed Test: {1, 2, 3, 4, 5, 6, 7, 8, 9} {2, 3, 1, 5, 6, 4, 8, 9, 7} {3, 1, 2, 6, 4, 5, 9, 7, 8} {4, 5, 6, 7, 8, 9, 1, 2, 3} {5, 6, 4, 8, 9, 7, 2, 3, 1} {6, 4, 5, 9, 7, 8, 3, 1, 2} {7, 8, 9, 1, 2, 3, 4, 5, 6} {8, 9, 7, 2, 3, 1, 5, 6, 4} {9, 7, 8, 3, 1, 2, 6, 4, 5} Expected: False But was: True
Why this test is false ??
check the 3x3 subsquares
Does this clarify things?
oh thx :D i forgot it
then what row and column incorrect ?
All columns are correct, and all rows are correct. But blocks (3x3 small squares) are not correct.
Add this tests to your solution and check it:
Even though I see your point, why would you even try data outside the valid inputs?
This comment has been hidden.
The board is always 9 cells by 9 cells, and every cell only contains integers from 0 to 9.So, this is not within the scope of kataThe test code doesnt check for whole rows and columns. It only checks 3x3 squares.
In scala, the first and third tests in the main attempt seem odd:
6 7 2 1 9 5 3 4 8 1 9 8 3 4 2 5 6 7 8 5 9 7 6 1 4 2 3 4 2 6 8 5 3 7 9 1 7 1 3 9 2 4 8 5 6 9 6 1 5 3 7 2 8 4 2 8 7 4 1 9 6 3 5 3 4 5 2 8 6 1 7 9 should be valid
4 9 8 2 6 1 3 7 5 7 5 6 3 8 4 2 1 9 6 4 3 1 5 8 7 9 2 5 2 1 7 9 3 8 4 6 9 8 7 4 2 6 5 3 1 2 1 4 9 3 5 6 8 7 3 6 5 8 1 7 9 2 4 8 7 9 6 4 2 1 5 3 should be valid
Already reported.
This comment has been hidden.
Please specify the language. Also specify which case / what code generates false positives. (otherwise this isn't a valid issue)
This comment has been hidden.
The lack of tests (fixed and random) is already mentioned in more than one open issue below, can we close this one?
Here there're multiple twos in the second and third rows,
Test(True,[Int32[], Int32[], Int32[], Int32[], Int32[], ...]) Test Failed Test: Here: {5, 3, 4, 6, 7, 8, 9, 1, 2} {3, 7, 2, 1, 9, 5, 3, 4, 8} {4, 2, 8, 3, 4, 2, 5, 6, 7}
{6, 1, 3, 7, 6, 1, 4, 2, 3} {7, 9, 4, 6, 5, 3, 7, 9, 1} {8, 5, 2, 1, 3, 4, 8, 5, 6} {9, 3, 5, 4, 7, 8, 2, 8, 4} {1, 4, 6, 2, 9, 5, 8, 3, 5} {2, 8, 7, 3, 1, 6, 4, 5, 9} Expected: True But was: False
Yet it expects true, I'm sorry But I didn't get it so far, Could someone please explain?
so, you didn't find a solution to copy on the web for this one, yet? Surprizing...
Anyway. When you post an issue (or even a question), don't forget to state the language. For instance, I checked C, C++, JS, C# and python (those you seem to practice), and none of them has a test with this input.
Hence, I bet you're mutating the input, so it's not surprising you end up in a mess.
Closing, as it's not a kata issue.
cheers
Haven't you found a better reply other than being insultive and accusatory?
Anyhow Thanks, I solved it and passed the tests. And I'm still waiting for an external link that the solution was copied from, Or more testcases to see if it was a 'cheat'.
did you say...? So nothing offensive when it's only truth, no? x)
Anyway, to answer your question there, points can be removed, yes (will happen at some point, but when...? that's another question). But then, you cannot complete those kata anymore. And if your account get banned, you can create another one, yes (not with the same name).
My reply above was speaking about this particular kata, I didn't try to mutate the input to solve it nor copy an exisitng solution for it.
Anyhow, thanks again.
Log [[1, 2, 3, 4, 5, 6, 7, 8, 9], [2, 3, 4, 5, 6, 7, 8, 9, 1], [3, 4, 5, 6, 7, 8, 9, 1, 2], [4, 5, 6, 7, 8, 9, 1, 2, 3], [5, 6, 7, 8, 9, 1, 2, 3, 4], [6, 7, 8, 9, 1, 2, 3, 4, 5], [7, 8, 9, 1, 2, 3, 4, 5, 6], [8, 9, 1, 2, 3, 4, 5, 6, 7], [9, 1, 2, 3, 4, 5, 6, 7, 8]] True should equal False
can u take a look on that please because i dont know it should be fine
This comment has been hidden.
ya my bad thanks.
I have have a False positive for the sudoku below, and I can't find what is wrong with it (not with my code with the soduku).could you please explain to me?
Take a look at the last 2 columns, the 3s and 5s.
thank you
Isn't this kata asking the same as the one on the link below? I used the solution i had to the linked kata and it worked on this one because they are both asking the same despite being different levels supposedly. https://www.codewars.com/kata/53db96041f1a7d32dc0004d2
Yes, this one is older tho.
Hi looking at the test: Test.assertEquals(validSolution([ [5, 3, 4, 6, 7, 8, 9, 1, 2], [6, 7, 2, 1, 9, 5, 3, 4, 8], [1, 9, 8, 3, 4, 2, 5, 6, 7], [8, 5, 9, 7, 6, 1, 4, 2, 3], [4, 2, 6, 8, 5, 3, 7, 9, 1], [7, 1, 3, 9, 2, 4, 8, 5, 6], [9, 6, 1, 5, 3, 7, 2, 8, 4], [2, 8, 7, 4, 1, 9, 6, 3, 5], [3, 4, 5, 2, 8, 6, 1, 7, 9]]), true);
According to the definitions, every sub grid 3X3 should contain 1-9 digits. As far as I see, please look at the sub grid starting on position [0, 2] - the number 4 See that it's missing number 5: 4,6,7 2,1,9 8,3,4 Maybe I miss something. Thanks
Please follow the link to Wikipedia to see an example of sudoku board and what a valid "sub grid" is. Not every 3x3 square of the board is a subgrid where the rules apply, there's only 9 of them.
So I searched for that and I found: Each of the 9 sub-squares, of size 3x3, contains a unique value from 1-9. This is what I mean, there for that square is not valid. So why should I get true ?? Thanks!
Those are the 9 sub-squares, the one you picked isn't one of them.
Thank you so much !!!
no idea why i'm failing that final test :'(
anyone know what's different about it?
EDIT: solved it tried checking for things that weren't equal instead of checking for things that were ;)
I cant get passed the final test no idea whats going wrong my algo returns true but the test is False only i dont see how its false
[1, 2, 3, 4, 5, 6, 7, 8, 9] [2, 3, 4, 5, 6, 7, 8, 9, 1] [3, 4, 5, 6, 7, 8, 9, 1, 2] [4, 5, 6, 7, 8, 9, 1, 2, 3] [5, 6, 7, 8, 9, 1, 2, 3, 4] [6, 7, 8, 9, 1, 2, 3, 4, 5] [7, 8, 9, 1, 2, 3, 4, 5, 6] [8, 9, 1, 2, 3, 4, 5, 6, 7] [9, 1, 2, 3, 4, 5, 6, 7, 8]
Check the posts already here, like FlintOFF's one below.
This comment has been hidden.
don't ever mutate default arguments in python (hence don't define b2 and b3 like you do now). Print them at the beginning of your function, and look at what happens at each call.
thanks, mate, I did what you suggested and it worked. But when I copied the 3rd test case to my personal IDE, surprisingly it returned the expected output (True). But here, it returns False with my above code. Can you please explain why did that happen (when I modified the default arguments)? or, suggest any article about it? (I would be really grateful ☺)
this default argument thing is one of the worst trap of python. They are defined in... sort of an independant scope at function's creation time, once and for all calls you can do to the function (on the contrary of JS where every default argument is declared again at each call. Maybe one of the few things where JS is good at... XD ). Hence you get the very same instances of those lists at every call and if you don't clear them properly, they still hold your previous computations.
article_1
article_2
article_3
It cold be that you are misreading the logs off by one? The log appears above the test result
Expected 'true' on input of
- Expected: true, instead got: falseExpected 'false' on input of
- Expected: false, instead got: trueAnyone know why this happen? Both same input but expecting a different output?
Can you tell me when a board would be valid?Yes, you're mutating the input.You're probably mutating the input and then the error message seems wrong. I've created an issue about that 6 months ago.
This comment has been hidden.
https://github.com/codewars/codewars.com/wiki/Troubleshooting-your-solution#print-input
This comment has been hidden.
Not an issue. 7th column has multiple
3's.Damn Thanks man.
I gotta read the instructions better.
@tsp888 if you are noob here, please check the last asked questions in the discourse section.
If you'll scroll down you'll find atleast 20 such questions.
This comment has been hidden.
Sory for my bad English, But I think that this Kata must have more tests, for example, I write a simple code where I counting amaunts in every 3*3 square, in every horizontal and vertical line and compare this sums with 45(it is a sum from 1 to 9). [ [4, 3, 4, 6, 7, 8, 9, 1, 3], [6, 7, 2, 1, 9, 5, 3, 4, 8], [2, 9, 8, 3, 4, 2, 5, 6, 6], [8, 5, 9, 7, 6, 1, 4, 2, 3], [4, 2, 6, 8, 5, 3, 7, 9, 1], [7, 1, 3, 9, 2, 4, 8, 5, 6], [9, 6, 1, 5, 3, 7, 2, 8, 4], [2, 8, 7, 4, 1, 9, 6, 3, 5], [3, 4, 5, 2, 8, 6, 1, 7, 9] ] - this is the test where my solution does not work, but with my silution I passed all the tests. There you can see my code - https://pastebin.com/PDuUXBYs I hope that not only me find this problem, sorry if I copy someones issue
Yes, there are already several open issues about the tests, so I'll close this one.
Test: {1, 2, 3, 4, 5, 6, 7, 8, 9} {2, 3, 1, 5, 6, 4, 8, 9, 7} {3, 1, 2, 6, 4, 5, 9, 7, 8} {4, 5, 6, 7, 8, 9, 1, 2, 3} {5, 6, 4, 8, 9, 7, 2, 3, 1} {6, 4, 5, 9, 7, 8, 3, 1, 2} {7, 8, 9, 1, 2, 3, 4, 5, 6} {8, 9, 7, 2, 3, 1, 5, 6, 4} {9, 7, 8, 3, 1, 2, 6, 4, 5} Expected: False But... It's returns true;
and each of the nine 3x3 sub-grids (also known as blocks) contain all of the digits from 1 to 9.
Not an issue.
Test: {1, 2, 3, 4, 5, 6, 7, 8, 9} {2, 3, 1, 5, 6, 4, 8, 9, 7} {3, 1, 2, 6, 4, 5, 9, 7, 8} {4, 5, 6, 7, 8, 9, 1, 2, 3} {5, 6, 4, 8, 9, 7, 2, 3, 1} {6, 4, 5, 9, 7, 8, 3, 1, 2} {7, 8, 9, 1, 2, 3, 4, 5, 6} {8, 9, 7, 2, 3, 1, 5, 6, 4} {9, 7, 8, 3, 1, 2, 6, 4, 5} Expected: False But was: True
not an issue. Read the specs of the sudoku game again.
Not an issue.
This comment has been hidden.
Do you use any global variables, or static variables, or whatever it's called in your language, which might carry some state between executions of your solution? Did you try to run in your IDE more than one test case in one go?
It says True should equal False, but I can't spot the problem
[[1, 3, 2, 5, 7, 9, 4, 6, 8],
[4, 9, 8, 2, 6, 1, 3, 7, 5],
[7, 5, 6, 3, 8, 4, 2, 1, 9],
[6, 4, 3, 1, 5, 8, 7, 9, 2],
[5, 2, 1, 7, 9, 3, 8, 4, 6],
[9, 8, 7, 4, 2, 6, 5, 3, 1],
[2, 1, 4, 9, 3, 5, 6, 8, 7],
[3, 6, 5, 8, 1, 7, 9, 2, 4],
[8, 7, 9, 6, 4, 2, 1, 3, 5]]
This is the only one failed outta six random tests
This comment has been hidden.
Not a kata issue.
Falseis correct output for this test case. Reproduce the test case locally and debug through it in your IDE, it should help.I've just spot the problem in my codes now.
Thank you for the reaction :)
This kata still needs more random tests tho :(
It says True should equal False, but i am getting False [[1, 3, 2, 5, 7, 9, 4, 6, 8], [4, 9, 8, 2, 6, 0, 3, 7, 5], [7, 0, 6, 3, 8, 0, 2, 1, 9], [6, 4, 3, 1, 5, 0, 7, 9, 2], [5, 2, 1, 7, 9, 0, 8, 4, 6], [9, 8, 0, 4, 2, 6, 5, 3, 1], [2, 1, 4, 9, 3, 5, 6, 8, 7], [3, 6, 0, 8, 1, 7, 9, 2, 4], [8, 7, 0, 6, 4, 2, 1, 3, 5]] False
Read this. See if you didn't miss something, and if not, provide your code following the instructions in the link.
I solved it. The matrix i posted was not related to the "True should equal False" message. I forgot to check, if vertical and horizontal lines are correct.
This test must returns TRUE instead FALSE [[1, 2, 3, 4, 5, 6, 7, 8, 9], [2, 3, 4, 5, 6, 7, 8, 9, 1], [3, 4, 5, 6, 7, 8, 9, 1, 2], [4, 5, 6, 7, 8, 9, 1, 2, 3], [5, 6, 7, 8, 9, 1, 2, 3, 4], [6, 7, 8, 9, 1, 2, 3, 4, 5], [7, 8, 9, 1, 2, 3, 4, 5, 6], [8, 9, 1, 2, 3, 4, 5, 6, 7], [9, 1, 2, 3, 4, 5, 6, 7, 8]]
I'm not sure what you mean, but the expected result is
false, and that is correct.Please check again, because
falseis not a correct result. I provided an array from the test, and this array absolutly correct. You can check by yourself, each row and column should have values from 1 to 9 without duplicates or zeros.No, false is the right result.
You can check by yourself, each row and column and 3x3 sub-square should have values from 1 to 9 without duplicates or zeros.
falseis correct result for this input.Yep, my mistake, thanks for the reply Sorry about that.
This comment has been hidden.
This comment has been hidden.
There are no random tests!
It has already been mentioned as an issue before.
5 tests are not enough really...
Duplicate issue.
My code passes 5/6 checks. True should equal False. Is it possible to see how the Sudoku he decides is not correct?
you can print the input board and check out what you are missing out;)
Some details here: https://github.com/codewars/codewars.com/wiki/Troubleshooting-your-solution#print-input
I think the description needs a small fix, it says "...and every cell only contains integers from 0 to 9", but the integers are actually from 1 to 9.
It can also be a 0 :'The cells of the sudoku board may also contain 0's, which will represent empty cells.'
In Scala, test cases have multiline names, and this causes confusing behavior. Part of the name (first line) is used as header of collapsible test case section, and remaining lines appear in a way similar to stdout log output. This can (and does, see post below) cause confusion and problems with correct interpretation of log messages.
This comment has been hidden.
I haven't solved it in Scala so it is possible there's some issue there, however, for such a basic test case, I kinda doubt it. Please read this point of the troubleshooting FAQ, especially bullet point no. 4, and see if it helps. I will check Scala version later today, but still I am pretty convinced the error is somewhere in your solution. If you find it, remember to mark the issue as resolved.
@hobovsky: we'll need to add a point about "my code doesn't output the same on cw and my local environment"
-> global vars / language versions / mutation of the input / hidden memoization (python specific, with mutable default arguments) / ...?
That's basically what I meant
"My solution works "on my machine", but fails when I submit it to CodeWars. Why?"to be, in particular the point about state being carried over between invocations of solution. I did not think of all scenarios apparently, and sure, we can add them there.:+1: right, it did sound familiar but I didn't check.
This comment has been hidden.
I just solved the kata in Scala and encountered no problems. I am going to close the issue here as not a kata bug. If you want us to take a look at your solution, post it here (remember about markdown code formatting and spoiler flag) so we could take a look at it.
Interleaved tests output can be a sign that test runner executes tests in parallel, but AFAIK there were some countermeasures taken against such behavior. I will verify if it's indeed the case. This can also cause some problems if your solution has some state, but you said it does not.
Hey
I found the error, just the test output was a bit misleading. The multiline test name was rendered a bit weirdly and the copy of the test input was missing first row, which lead to me testing with ilformed matrix which caused the test to work locally, but invalidating the input for different reason. The real reason was wrongly formed sub matrices.
Also the log of the test included stuff from the following test.
I did notice a bit unusual display of test cases, but I did not see it's that confusing. It's probably of no help for you anymore, but I rased appropriate issue above.
No biggie, fixed my solution, now that I know that that kind of thing can happen when rendering test results I'll know how to interpret the output next time and won't waste time on the wrong thing.
Since there already is a 4kyu kata to Validate NxN sudoku (https://www.codewars.com/kata/540afbe2dc9f615d5e000425) that uses OOP and validates sudoku of arbitrary size, I am really surprised that this is 4 kyu and I see that a lot of others are voicing similar opinions.
This is an early kata from 2013. A few years ago katas were ranked lower difficulties, than in the early years and the ranking system was changed. So you are definitely right.
There are two options. Reranking the old katas and as a consequence decrease the points of guys that took points for those kata. Option two is to accept this and grab some easy points.
I am not aware of plans for reranking. Perhaps a moderator is.
Cheers.
I see, thanks for letting me know. I am fairly new to codewars and only now started discovering these inconsistencies, but was pretty sure that the community is aware of this issue for quite some time.
too easy for 4 kyu
This comment has been hidden.
Do you know the input of failing test case? Did you try to recreate it locally?
Yes I did. I got the board using print statement. On running locally, it sucessfully returns false.
Your handling of columns is invalid. In following test case:
column 7 is invalid, but your solution returns True.
Resolving as not a kata issue.
This comment has been hidden.
See if you can find any help here.
Not a kata issue.
The input to the tests are easily available by printing them thus:
Next, review the definition of
blocksfrom the description.Your code fails on validation of 3x3 blocks it seems
This comment has been hidden.
first, check that you're using the correct input to compare to the expected result: when you log something to the console, it appears above the related assertion.
About the "issue/not an issue" part, this isn't an issue because all tests are correct. Hence this should be posted as a "question" (issue= wrong kata / question=user having trouble to solve the kata)
Generic message below (som parts do not apply here), where you'll see your messages are still missing important informations so that we actually can help you (ex: "I got the input by printing to the console" doesn't ensure us that you're using the actual input of the failing assertion, as said above):
Seems you're "rather new" to cw, so here are some general guidelines about the comments:
Issue: problem in the kata itself (description, wrong tests, wrong internal solution...)Suggestions: well, I guess that part is clearQuestionanything else that is related to you having a problem solving a kata -> that's you, currently.When you post issues:
When you post a question: well, most of the above apply too x)
When you post code, use proper github markdown, so that it's readable.
cheers
Your solution fails for following test case:
7th column is invalid, but your solution retrns True.
I confirm your code returns
True, my python version is3.6.9. Due to the indentation ofhorizontal.clear() vertical.clear() matrix1.clear() matrix2.clear() matrix3.clear()The initialization of the same lists won't take place more than two times.This comment has been hidden.
You can see other users solutions and learn a few things that way too.
Why this sudoku is not vaild? [ [ 1, 2, 3, 4, 5, 6, 7, 8, 9 ], [ 2, 3, 1, 5, 6, 4, 8, 9, 7 ], [ 3, 1, 2, 6, 4, 5, 9, 7, 8 ], [ 4, 5, 6, 7, 8, 9, 1, 2, 3 ], [ 5, 6, 4, 8, 9, 7, 2, 3, 1 ], [ 6, 4, 5, 9, 7, 8, 3, 1, 2 ], [ 7, 8, 9, 1, 2, 3, 4, 5, 6 ], [ 8, 9, 7, 2, 3, 1, 5, 6, 4 ], [ 9, 7, 8, 3, 1, 2, 6, 4, 5 ] ]
Not only rows and columns must contain the numbers 1 to 9. The nine 3x3 matrices also must contain number 1 to 9. The top left hand 3 x 3 is:
This matrix should not contain equal numbers. Check the sudoku rules on the given site.
check 3*3 sqrs