7 kyu
Say hello!
829 of 6,490nakulgupta18
Loading description...
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
nice
Ruby: only 3 fixed tests, and no random tests
fixed
Python translation with random tests
I would say its 8kyu not 7kyu really. If it makes any difference :P
Ikr
The problem should work with or without the exclamation mark at the end, because it's just frustrating that an error pops just because I'm missing an exclamation mark.
And what's the problem with adding the
!
at the end of a string?I didn't say it was a problem, I only said it doesn't need to be mandatory as it is unclear in the instructions that it's required to be written
Maybe some people don't know how to add that. Its simple kata so its checking basic skills. Some may struggle
In C#, there are only seven fixed tests. Needs random tests.
In C#, the expected and actual fields for tests are backwards.
Additionally, the method name
greet
should beGreet
, as public method names arePascalCased
in C#.This kata isn't working properly in ruby toward the greet("") (if name is empty ). Says it expect nil and...When it gets nil it doesn't work.
Can't use ES6 arrow function as
greet
has already been definedFixed. Please mark resolved, because I can't.
(You already could if you defined
var greet =
instead ofconst greet =
.)Hey! Now I can mark resolved.
Your opinion has been duly noted and ignored.
The kata is what it is and the test cases are sufficient.
Feel free to make suggestions.
The comment in test case is too short. It should tell the me what is the expect output and my output so that I can understand what is wrong with my solution
Cannot reproduce issue. May have been solved without being marked solved.
Please add more test cases (before submitting).
Please note it is possible to add example test cases for your solution yourself.
Added one for null input anyway.
cool!
Marking an issue! Not so cool! :]
The one tag (hello) is not useful in understanding the actual purpose of the kata.
Fortunately, the description fully clears up said purpose.
Hi! :]
Better failing test feedback would be an improvement, or more tests
Issue not reproducible. May have been solved without being marked solved.
Feel like this one is a little too simple and there are already challenges that touch on the same topic
Well, 8 kyu is for the simplest kata (or there'd be a 9 kyu rating).
There will always be beginner kata that seem alike. Just say hello again. :P
yeah but this is ranked as a 7 kyu?
Hello starting with capital H gives error, the kata only accepts hello with small H.
Which is specified in the description.
The kata is what it is.
Says to return nil but expects null
Description modified.
Issue closed.
null, not nil
Description modified.
Shall we close the issue then?
var greet = function(name) { return "hello " + name + "!"; }; greet("Niks");
Passes until you submit?
You aren't handling when an empty string is passed in. You need to return null if an empty string is passedd in
Description is adequate. Not a kata issue.
I agree you should say return null, not nil, just to make it a little clearer
done.
done.
done.
Should say to return null, not nil for non-"real names".
What do you mean about "real names"?
Is this in Description or in comments?
Issue does not seem to be with kata.
Needs more test cases. Description needs to use word 'null' instead of 'nil' for javascript.
or I'd rather return undefined in this case, not null
It uses
null
now. Output is specified for tested inputs. Shall we leave it at that?Test case failures could be explained in more detail.
already explained.. thanks
Tests give no information about the input or expected output.
Tests are insufficient, kata can be passed by hardcoding return string.
Kata is a duplicate of the many other 'say hello' kata.
Returning different data types from a function is bad practice.
this kata is for beginners and I tried to keep it as simple as possible. thanks for your suggestions, will take care in future..
You may want to be more explicit with your test cases. This is clearly for new people - provide some context for what might be going wrong if it doesn't pass. (Is it a string? Is it empty?)
done. thanks
This kata doesn't clearly describe the inputs/outputs it wants
it's pretty simple.. For an input of a string it should return hello string! and for invalid strings like empty string or nil values it should return nil.
what's expected if
name
's empty ?you wont say hello to an empty name :)
Of course, but what is expected answer :
nil
Thx. (It would be better to precise it in the Description)
done.. thnx