7 kyu
Regex validate PIN code
67,938 of 183,397JMurphyWeb
Loading description...
Regular Expressions
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
This comment has been hidden.
This comment has been hidden.
This is not an issue with the kata, this is an issue with your code. The input that you're failing on is not
123, look more closely.A simple but very interesting Kata. Grate job with the test cases. :D
I would suggest to include links to learn the topics that are labeled.
Kata description should not contain external links, all information && requirements should be contained within, and if any other information is required due to a lack of knowledge or understanding, then it is up to the solvers to dig the info themselves (very easy these days ~~ ^^
Any recomendation on a good resource on java regex topic?
First Google Search Result
This comment has been hidden.
Everything is going well on my PC, but the site gives an error on the combinations ( 123 ) and ( 09876 )
In that case, your PC is unaware of the nature all edge cases provided by the kata on this site, and your code is incorrect because it does not handle these edge cases. Please look very carefully at the error messages to debug your code. Good luck.
well, the test output is poor, for example:
testing for validate_pin('\')which is invalid syntaxfork that adds repr(pin) to python so that the string literals are string literals instead of vaguely looking like string literals while actually being text plus quotes which is worse than showing nothing because it's misleading
Above fork approved.
This comment has been hidden.
Groovy Translation (It doesn't use regex)
Approved.
I do not believe this is 7kyu and my answer was NOTHING like the common answer. Also, this example is very strange because in what world are people entering PINs like -1.234?
The kata is labelled with
Regex, and you chose to avoid it :PThat's literally the point of this exercise: to validate the inputs. In the context of ATMs maybe it's not so accurate (probably impossible), but from 3rd example in description it should be clear that theoretically any data could be in input.
It seems fine for 7kyu, especially if you use regex.
This comment has been hidden.
This might help
"-1-234"
is this legal? it is 4 digits[-1,-2,3,4] Also it has 6 characters.
Test Failed Wrong output for "1234" Expected: False But was: True
This is wrong, It should expect True not False
C#: Notice the linebreak in the assertion message, Your code works incorrectly for inputs like
"1234\n".(Resolving: Not a kata issue)
You are absolutely right. I going to adjust my approach. Thank you.
getting the same error, the tests of the creator were not well implemented
It was implemented correctly, your code just needs to check whether it has \n.
This comment has been hidden.
The input is
"1234\n". I can;t remember exactly how it works in Java, but in some implementations,$can successfully match a final newline, resulting in wrong answers for this challenge.Oh thanks I didnt know that
$can successfully match a final newline.Hi, I don't understand why my code do not work on the plateform. It's work on my computer. The test do not pass for '123' and '09876'. Thanks in advanced,
Hi,
Your code works incorrectly for inputs like
123\nand09876\n. Your solution has a bug, it is not a kata issue.Ok thanks you ! I don't see the return to line. Sorry !
Similar issue to others. "Expected: false, instead got: true" for "567890".
If this case should return false, the description is broken, because full conditions are not explained.
This test case is exactly six digits, and contains only numbers -- per the description, 'true' should be the answer.
ok, took a look at someone else's thread below and discovered it's a newline issue.
This is a rank 7 kata. Lots of folks are gonna come across this who are just learning to code. You're setting a ton of people up for failure here with this trick.
I can take being a dummy for a sec, I've been coding for a while. But for other folks, highly recommend adding a line at the end of this description like "hint: consider newlines" or better yet, just adding a case to the visible tests that includes several newlines at the end.
Looks like I'm running into similar problems as a lot of others here. Passing nearly every test except for "Wrong output for '1234 ': True should equal False"
Which doesn't make any sense to me. I think this kata is broken.
Your solution thinks that strings with a newline at the end are valid PINs.
This comment has been hidden.
Description of
$in the docs onreshows that it can actually be the issue.It can be checked easily simply by running following test case:
test.assert_equals(validate_pin("1234\n"),False). Your solution will returnTrueand fail the test.I see! Thanks for the clarification.
This comment has been hidden.
This comment has been hidden.
The worst kata.
I don’t know regex, so I don’t do it that way — is that bad? If you’re lucky, you’ll solve it quickly; otherwise, it can be quite troublesome. I think this kata is not suitable for level 7, or the test cases need to be simplified.
I suggest you learn regex before trying to solve katas that have Regex in their title, otherwise, you'll find them more difficult than they are.
You're probably right. I found this kata in unfinished.
You don't need regex, you can search in string methods for one that checks if a string only contains numbers.
I know. I solved this kata.
Has anyone experienced a test failure with this error: Wrong output for '123 ': expected true to equal false
Know that instead of the 4th digit there is an \n
What is your suggestion tho?
solve the problem through regex, and not by splitting the string into an array
Not a kata suggestion
This comment has been hidden.
Your solution is just buggy. It does not handle trailing whitespace correctly. It is not a kata issue.
when i click "test" it passes) when i click "attempt" it fails
Not a kata issue, your code is failing for such cases -->
1234\n567890Lua translation!
Approved
Due to an error in the tests, it is impossible to solve this problem!
What error? In what language?
Your solution returns incorrect answer for
pin='123\n'.Please specify the conditions in the description and show the actual tests. My code fails at the edge cases test and I can't figure out why
The same thing happened to me...
This comment has been hidden.
You can learn about Markdown.
This comment has been hidden.
Kata hint != kata suggestion.
It seems that my code works on my computer "visual studio code" yet it brings out errors here.
Your code is wrong. It should return either
TrueorFalse, a boolean value, not a string. See the sample tests.The fact that I can't see the result of the failing test is a problem here. There is no reason to hide a failing test, I don't know what to investigate.
And this is the main purpose of testing, helping you to investigate. So it's pretty weird.
I'm just gonna skip this one.
You can print the input yourself, can't you?
No, I'm talking about what happen when you click on "submit". I don't see how I could print anything then.
Try with
puts "<" + pin + ">".This kata was quite challenging for me! I couldn't use the methods I'm accustomed to in Visual Studio. Nonetheless, it's a good, mind-puzzling exercise. Will try and finish it when i have the time.
This comment has been hidden.
Looks like a lot of people didn't expect the kata to test for input validation & edge cases with hard-to-see characters
tested on my pc, code works with this samples. here its occurs an error with the same samples
No, they're not the same. The input here is a string. Not a kata issue.
This comment has been hidden.
should handle all edge cases Wrong output for '123 ': expected true to equal false
what does it mean??
for the test '123 '
your code returned
truebut it was expected that your code should return
falsefor that testtake note that at the end of the test input, there is a newline
(
'123\n')This comment has been hidden.
Nice kata :) Good explanation and nice examples.
can someone clarify what does that mean : should handle all edge cases Wrong output for '123 ': expected true to equal false
See where the closing quote is.
does that mean the input have space like this "123 " ??
No, there's a newline after the third digit: "123\n".
That's why the closing quote is below the digits.
Your code should be able to handle edge cases like the stated above.
This comment has been hidden.
Your condition is wrong.
andstatements are executed first beforeorI got the solution, but my code is not clean :/
after going through the discussion I tried it but the answer seems still the same Wrong output for '098765 ': True should equal False \n newline character didn't work either \s character didn't work I first thought its space character issue , still no idea how will it work while there's this one person in the discussion claiming it's possible I wonder how
Why are you returning true for that input?
Not a kata issue.
You accidentally edited the edge cases to have a space.
yes i have the same problem
This comment has been hidden.
andhas priority overor, so if you want to evaluate anor-statement first, you have to use paranthesis.This comment has been hidden.
This comment has been hidden.
Your solution is incorrect. It returns
truefor inputs which are not valid PINs, like"1234.0".your solution has a bug, it's not a kata issue.
This comment has been hidden.
It's completely valid kata, try revising your solution.
This comment has been hidden.
The same problem: Wrong output for '123 ': expected true to equal false I've checked in another APP, '123' is falsy, but here - not. Probably a bug!
Look where the closing quote is in the error message, the input is not
'123'there. Not a bug. The post below yours is about the same, please read it.I have tried all i could, but i keep on getting this one error: "Wrong output for '123 ': expected true to equal false". I am very sure about the workability of my code. Maybe you are not.
See where the closing quote is in the error message. Read two posts below yours: https://www.codewars.com/kata/55f8a9c06c018a0d6e000132/discuss#64e7883f787eda26b30132c6
I must say, the Kata description is quite disappointing. It lacks any sort of detail, and I think it would be beneficial for the author to take some "description" lessons. If you could expand on the information provided, it would be much easier for users to account for all necessary situations.
The description gives all the details necessary to solve the task. Also your suggestion doesn't make any concrete suggestion, it is just vague criticism and hardly could be really helpful. If you have a concrete suggestion to improve the description, go on, but not this please.
I have this output and i dont know if it is fine, I dont know if that jump space is an char as \n or something else, but i tryed to format with a regex and pin.tim() ... =>
Wrong output for '123
': expected true to equal false
The closing quote is in a new line, yes, there is a \n there.
I tested my code on my local webpage with a number of different inputs ranging from 1 - 7 characters with and wihout alphabetic characters and all answers come up as correct and showed the results to another person and they verified it was working, so, as far as I'm concerned this is a win. My code may suck, no it really does, but it does work just won't work here. Been fun being my told doesn't work when it does.
If anyone says the problem is in your code - well tell that to the other person who saw it working.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
Unsolvable due to broken test case. '1234' and '098765' occure twice once as valid pin and once as invalid pin.
There's nothing wrong with the test case, apparently your solution failed on
1234\nand098765\n. The\nis not visible in the error message (since it's new-line character). I think that's why you assumed it's1234and098765when it's not.Wasn't counting on newlines being tested.
Would there ever be a pin string containing '1234\n567890'? Shouldn't code validate one PIN per call? This is unbelievable...
This comment has been hidden.
Pretty sure it does, the problem is in your code.
The important is not the completions but the percentage here. E.g: 1 milion of people over 3000 milion is meaning nothing.
Plus you are not the first I see posting this very same message with data meaning nothing and in the edge of the criticism just 'cause others doesen't do as "good" and "fast" like you. You can say the same thing with more emphatic and kind words. This apports nothing.
Sorry but I don't see the problem with my answer, he said it doesn't work when it does, and I gave him proof that it does (but for you, it means nothing). I also told him to check his code, the problem was there, not in the kata. What more should I do?
I know you gave an example, but where did you get your numbers? Check them before posting something that's not real:
That's more than 50%, but that's for every language, I can't tell you the exact number in Python.
This comment has been hidden.
Please use the spoiler flag when posting spoilers. I flagged your comment as as spoiler for you this time. See https://docs.codewars.com/training/troubleshooting/#post-discourse
Answering your question: you're misusing regex flags.
This comment has been hidden.
Hi, i don't understand this fail test:
ValidatePin should return false in various edge cases Test Failed Wrong output for "123 " Expected: False But was: True
Ok, there shouldn't be whitespace in pin so put that condition : pin.Contains(" ") ? false, nut it's not working! Why it is so?
The closing quote is in the next line, so the char isn't a literal whitespace.
Just keep trying to simplify your goal. Be as general as possible. What data type should every element of the string be?
Scala translation
LGTM, Approved!
Why are they saying that if the PIN contains letters, that it should return false no matter the length, when you could just accept int instead of string? IRL when you go to an ATM it'll only have numbers on the keypad, and if you look on the website, if you try to put a letter instead of a number, it'll just not allow right?
I am so noob I can't fix aplphabets other than that I fix floats
This comment has been hidden.
This comment has been hidden.
+isn't a digit. It's obviously false.This comment has been hidden.
Please use the spoiler flag and appropriate formatting when posting code. See here: https://docs.codewars.com/training/troubleshooting/#post-discourse
You can use any function as long as you implement the correct validation logic. Usage of
Numberis not restricted for this kata.Your code is definitely incorrect if it fails for basic cases like
"1234". You must be incorrectly (locally) testing your function.Почему то выдает ошибку: Wrong output for '1234': expected false to equal true. Пин 1234 не проходит по условию
Check the failure, i suppose there is a "1234 ". There is a " " at the end. And it's on new line.
That check is a waste of time for such a petty problem like this.
This is the exact type of problem where being precise about your string validation is a good thing.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
Not a kata issue, read the posts below like this one, and write in english (use Google translate if you want) please.
Приетствую! Обрати внимание, что строка перенесена )
This comment has been hidden.
'000000' Im trying to understand why this string of zeros is unque compared to the other pins. This is the only error I am getting.
It doesn't pass the last condition of your if.
thanks for responding. I actually left a piece of old code in my soolution from a previous attempt that altered my results.
same here bro . did you solve it ?
This comment has been hidden.
There is nothing to fix, but your code. Not a kata issue.
The input is not
"123 "see where the closing quote is in the error message.I'm sorry for this task, which don't have clear tests. What is the input in the test, where I get an error? In the tests window, description of the test I bumped into is absent.
Print the input yourself to see what it is: https://docs.codewars.com/training/troubleshooting/#print-input
thanx
This comment has been hidden.
Please see this page for some honts how to debug your solution: https://docs.codewars.com/training/training-example#debugging-a-kata
This comment has been hidden.
This comment has been hidden.
Your solution returning wrong answers is not a kata issue.
somehow description says EXACTLY 4 or 6 DIGITS and whitespace score like digit? omg
It doesn't that's why 4 digits and a whitespace is not a valid pin.
This comment has been hidden.
Hello, DegaKiller! I don't know what your specific case is, but note that in some tests, pin = "123\n" or "1234\n" (line break, not space). I got caught on this and also thought it was a bug.
I managed to resolve. I was just complicating the logic a lot, I just reversed the reasoning and it worked. Thanks for the answer!
Generating regex is the best use I have found for copilot & other language processors.
This comment has been hidden.
ATM is an acronym for "Automated Teller Machine"... so it is redundant to say "ATM Machine". This irritates me!
"I forgot my PIN number."
This comment has been hidden.
Please read the posts below, it's been asked and answered many times already. That string has a trailing space or a new line (hard to know without markdown).
i found the same issue and realized what was the problem... extremely hard to solve it)) as for me not 7ky but, ty for this kata - forced to learn a bit
Well, I was going to complain about this kata but it seem that a lot of people already did that lol. I think it's broken, and I spent almost an hour breaking my head trying to solve it
122545 people who already solved this kata might disagree.
You transform each digit to a number and then check if it's not a number. This fails for some characters, e.g. white space.
seems 1234 doesn work this way Wrong output for '1234 ': expected true to equal false
Please read the posts below, it's been asked and answered many times already.
it is working.. so much reefs here..
This comment has been hidden.
See where the closing quotes are. The input isn't
"123". Read the posts below, there is nothing to fix but your code.extremely hilarious- "Wrong output for '123 ': expected true to equal false"
That's
'123 ', do you see 4 digits there? Your code returns true, when the expected answer is false.what the hell is wrong with this task?? is says "Wrong output for '1234': False should equal True" then I adjusted my code and it says Wrong output for '1234': True should equal False
Who made this ??
Read the error message:
See where the closing quote is. It's a problem with your code.
is there a space between 1234 and closing quote? I dont see the space or is it \n?
The latter.
Oh I think its this one '1234\n'
Thanks
This comment has been hidden.
Please don't post spoilers like that.
okay, i will not do that again
Hi everyone! I've got an error : "Wrong output for '123 ': expected true to equal false". What is wrong? "123" length is 3 but not 4, the function should return false. Or am I wrong?
That's exactly what error tells you, test expected false, but you returned true.
OP solved it, closing
This comment has been hidden.
OP solved it, closing
This comment has been hidden.
Function's name should be
validatePIN, notvalidatePin. Mark your post as having spoiler content next time, read this: https://docs.codewars.com/training/troubleshootingThis comment has been hidden.
Hey zahrakaabi, try reading all these comments and then think of another solution. You appear to have it mostly correct, but you need to check for another situation as well. You may read comments to figure it out and it should help.
Wrong output for '123 ': expected true to equal false .I got no ideas, my code works in vsc but for some reason in the example '123 ' JS does not catch the space in strict comparison.
Awesome, great news! You are very welcome.
Same issue here brother
This comment has been hidden.
Hi, dude, can u help me pls? Wrong output for '123 ': expected true to equal false .I got no ideas, my code works in vsc but for some reasons in the example '123 '
Think of a way to implement a check for an input with a break in the code, such as '\n'. Hope this helps, if not, let me know and I'll provide another hint. Check the comments below as well.
yes it helped, thank you very much
kata hint != kata suggestion
This one should not be the 7kyu. It is a little bit more difficult)
Totally agree! the number of edge cases is ridiculous
Sorry for the noob question. I am a but confused as I am getting a "Expected: false, instead got: true" when I try to attempt the kata so I printed the pin to console from the failed test and used the numbers so that my sample tests matched and all my sample tests are passing. I am not sure if the moderators are able to see my code to point me in the right direction.
The tests that I am using are below: 1, 12, 123, -12345, 1234567, -1234, a234, .234, 1.234, 00000000, 12345, 1234567890, 1234, 567890,
means that your code returned true when the answer is false
by changing the sample tests you can make the compiler expect the answer which your code is returning (which could be the wrong output)
This comment has been hidden.
I was able to figure out what is going on. One of the tests had a 4 digit and a 6 digit string separated by a new line. I adjusted the regex to account for this and now am passing the tests.
Thank you for your time.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
You changed the function's name, see the initial code on Python:
Not a kata issue.
smh... thank you very much! Sorry.
This comment has been hidden.
No, your code is wrong (and probably you're not using strings as input in those other places), fix it.
I did it without Regex, was challenging
How to fix this test Wrong output for '098765 ': True should equal False? Does it mean that we need to exclude \n? If so, how can we do this?
Yes, that's up to you. Not a kata issue.
This comment has been hidden.
oh nyo
A problem with your code is not a kata issue.
This comment has been hidden.
It's length, not lenght
Thanks, English is not my mother tong so I make a lot of mistakes like this.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
pin is a type of string
Hi all I have a error witn this: Wrong output for '1234 ': True should equal False and two line more I have other error witn the same error and other number. I think that after of number have a space, but i don't sura. Any idea...I put the regex and the others work properly. Thanks
Look where the closing quote is.
Yes, I see de closing quote. I put the next line in test "test.assert_equals(validate_pin("1234 "),False, "Wrong output for '1234 '")" and the return is ok but i go to attemp and i received two error of similar test. I had an idea...later I'll comment if I've hit the nail on the head. I see that it's not a space, it's a carriage return. Thanks
This comment has been hidden.
Read this: https://docs.codewars.com/training/troubleshooting#post-discourse
See where the closing quote is in the error message. The input isn't
'123'test for numbers starting the string and ending of the string
This comment has been hidden.
That's because your solution returns true while it should return false. And this is not a kata issue, an issue is a bug in the kata, not your code not working.
My first question is quiet incorrect. The exact error is "Wrong output for '123*': expected true to equal false" (where * is a space that was not appearing in my previous question).
It's clear why it's not valid. Read the description again if you have a doubt about it.
Okay, but I still don't understand why my code is working with this case on codepen and not here. That's why I thought there was an issue.
That's because that's not a space, it's an escaped sequence, a new line.
Okay, thanks !
I think there's a problem with the solutions.
The code works outside codewars.
@TIGOSTO your code fails with this input value:
"-1.234", it's in the sample tests.A little quibble about the task. In the examples, the output is true or false in lowercase, but in the tests the upper case is written.
This comment has been hidden.
Factor translation
Approved
theres definitely something wrong with "1234" case
"wrong" how? It should return
true, right?Yeah, it should... But regardless all logic it returns false. Idk why, everything else seems works fine but this '1234' is fricking f up
That's because it's not
"1234".MaxCherya: your code is wrong, numbers have no length property.
This comment has been hidden.
Because 0000 === 0.
This comment has been hidden.
I assume after seeing your profile that your language is Ruby (please state it clearly when asking a question). You can print the input with
putsin this language.This comment has been hidden.
Please use markdown tags to format your code or it's not usable. You can refer to the documentation about this and more: https://docs.codewars.com/training/troubleshooting/#post-discourse
puts pinprints correctly the input.I don't understand why I've got "Wrong output for '123': expected true to equal false"? In instructions: must be 4 or 6 integers. Here we have 3 integers. For sure in VS Code I've got False and it's right, but War Code expects True. How???? 4 or 6 integers needed else it should be False, but when there are 3 integers it says: "it should be True". How???
I think you are reading the Codewars error messages incorrectly: when you see:
"Wrong output for '123': expected true to equal false"
it means that you are returning true and the correct answer should be false.
The best advice to troubleshoot is to print the input (and your output if you want to see what your code is doing incorrectly) - you can learn how to do this here:
Print the input troubleshooting
This comment has been hidden.
Not a kata issue, that's a problem with your code, see the input of the test your code fails.
This comment has been hidden.
From the Description it is not completely clear what kind of answer should be returned: should it be a string or Boolean, according to Examples one can guess, that it should be a string beginning with a small letter. Trying this you understand, that you should write it with a capital letter, and only then trying to return “False” or “True”, one can get that it is a Boolean.
mmm...not really
in some languages (other than python which you're using), the booleans are
trueandfalse. you should return a boolean since thetrueandfalseare not stringified (don't have quotes around them).returning a string of either
'true'or'false'is pointless and it would be more logical to just return a booleanyes, I got it – be careful with quotation marks and not to forget, that it’s not only about Python here, thanks a lot!
I've got "Unauthorized" server response after clicking Test. Guys, please, fix the Codewars https://www.codewars.com/api/v1/runner/authorize back-end. It returnes 500 error.
I have the feeling there are missing instructions.. don't you? or something wrong in validation. doesn't make sense for a lvl 7 kata to point out 2 handle edge cases and the rest is passing. why 2 failed edge cases, 1234 and 098765, but it is ok for the other 25..., even the ones with same length... I made the test in python and it returns the correct value. Note that fails only in the part of 'Attempt' but when clicked 'Test' it passes all.
This comment has been hidden.
Please use markdown tags to format your code or it's not usable. Refer to the documentation about this and more: https://docs.codewars.com/training/troubleshooting/#post-discourse
so I guess everyone agrees, theres an issue with this solution
No.
For some reason in the example '123 ' JS does not catch the space in strict comparison. The code works correctly in the browser
Yes, with str = '123 ' in JS we have problem. but in browser its correctly....
the same, do u know how to fix it?
Can't understand why this test gives Wrong output for '1234 ': True should equal False. The rest is ok. Thanks in advance
Read the posts below, it's been asked and answered many times.
This comment has been hidden.
Your code is wrong, print the input to debug it. Not a kata issue.
Wrong output for '1234': expected false to equal true Why?
1234is a valid pin, your code returnsfalsefor that testHello, please advise! I have made a solution that passes all the tests given on codewars in repl.it, but is not working here, on codewars? Why is that happening?
You misplaced a
)ATM machines don't have '-' or '.' or anothe simbol on the keypad. Why is that something we would need to check for? Now there is critical wrong in information.
I think some time we should skip this wasting of times and go next level!
Try reading the posts below, you're not the first one to trip with that test.
This comment has been hidden.
Your function returns
true.C Translation kumited (author inactive).
approved
This comment has been hidden.
No, that's not it, use this:
puts "<" + pin + ">"to print the input.Got it. Thank you!
I was pulling my hair out trying to figure why my code was passing all of my tests on my side and failing when I tested it here, until I realized that the submitted pins here were strings, while my code was built to accept ints. Got to be more careful about noticing input types in the future!
Wrong output for '123 ': expected true to equal false
validatePIN("123"),false, "Wrong output for '123'"
Why?
There's a space after the 3, so it is four characters, but not all characters are digits.
So what is that symbol. In browser my code return false with "123 " param. But not here.
This comment has been hidden.
This comment has been hidden.
I see now, thanks!
This comment has been hidden.
This comment has been hidden.
Hey, maybe you're looking at output of another test (before or after). You are correct that "123" should return false. (test expects false too)
See if this article can help you: https://docs.codewars.com/training/troubleshooting/#print-input
because may be in this pin there is " " - secret space or anothe simbol.
This comment has been hidden.
Not a kata suggestion
This comment has been hidden.
If you return True with your second condition, your third condition is never considered, so actually this code cannot catch bad characters, it only controls the length. Your function ends as soon as it meets a
returnstatement.Thank You!
Python fork with improved tests logs (see discussion just below).
Approved, thanks!
This comment has been hidden.
https://docs.codewars.com/training/troubleshooting/#post-discourse
I'm not sure to understand your problem but as stated in the description, and as you can see having a look at sample test cases (just under the code editor window), the inputs in this kata are all strings.
307599 - False should equal Truemeans, necessarily, your function returnsFalsein this case. And the culprit is your code. This may help you debugging: https://docs.codewars.com/training/troubleshooting/I found the solution. The function input for the variable "pin" is ALWAYS a string... I was considering it any type of input (string, float, int) because the question did not mention anything about this! That's is why i had special cases for 0000 as integer (for example) which would translate to 0 in a variable... Unlike "0000" which is a string and will stay that way inside a variable.
The exercise should be more precise when asking us to do something :-/ i am not skilled enough to tell from the function itself, it needs to be inside of the exercise phrasing.
@akar what language is that? Looks scary!
The description says
If the function is passed a valid PIN string, return true, else return false., so I can't see the problem.Also, the title of the kata is
Regex validate PIN Code. Though the use of regexes is not enforced, regexes only apply to strings.And having a look at sample tests like I told you you would have seen you were passed strings. How would they pass you something like "a234" if it were not a string??
???
This comment has been hidden.
This comment has been hidden.
I think now I understand your problem (though I still don't get why your code would fail if it were correct), random tests display things like
testing for validate_pin(157704)(but alsotesting for validate_pin(xZxS2J?), which could have made you understand it was all strings), it would be clearer if the log wastesting for validate_pin('xZxS2J?'). I'll publish a new fork with this change.This comment has been hidden.
if you use char::is_numeric, it's not the one you need
This comment has been hidden.
Both expressions are the same. But if you fix that, check the input value in both places is the same your code fails.
This comment has been hidden.
Then your testing part isn't ok, yes, there is a newline.
Ok, I'll try fixing that. Thank you!
kill me please
I believe there's an error in the sample tests:
Test.assertEquals(validatePIN("123456"),false, "Wrong output for '1234567'")It's asserting that
123456should be false while123456is actually a 6-digit PIN code. Looking at the error message, I think the author wanted to assert1234567and not123456.If you have the right solution, you could be failing the TEST but passing ATTEMPT.
The test (in javascript) is like this:
If you see another thing, click reset.
It looks correct now!
This comment has been hidden.
Your solution is wrong, not an issue.
Can you show a case where it doesn't work correctly? He is not shown in output and I cant understand my mistake
This comment has been hidden.
Hi! I'm doing a task in Ruby I have read the assignment many times. But I can't figure out what I missed and why I get such a result:
Fixed tests Expected: false, instead got: true
The task is as short and clear as possible: "PIN codes cannot contain anything but exactly 4 digits or exactly 6 digits". But I have a feeling that not all requirements are listed. My code passes all the tests that are open to me. And I can't guess which requirement is "hidden" from me. Based on the tests that I can see, pincodes like '1111' and '123456' are allowed. Pin codes with hidden characters are not allowed by my regular expression. The code only allows a sequence of 4 or 6 digits and that's it. Please tell me where else to look
The validations are not working. My IDE returns false and the attempt outputs true for the same args.
This kata has been completed more than 86000 times. You must do something bad. This can help: https://docs.codewars.com/training/troubleshooting/
Hi! Did you find a solution? I have the same situation
Yes, I found the solution. My issue was that before finding the solution, Codewar was giving a wrong check on cases that were working.
The validations were never not working. Do you seriously think the "issue" just went away at the same time you "found a solution"? Blaming the site in this way is just an embarrassment.
I am not blamming the website. I love Codewars. Relax dude.
Absolutely false. You directly blamed the website in both of your comments in this thread.
This comment has been hidden.
This comment has been hidden.
Why would an empty string be true?
It is in the instructions, that's not 4 or 6 digits, isn't it?
This comment has been hidden.
Not a kata issue, look where the closing quotes are, fix your code.
Wrong output for 0000 , 1234 , 123456. It passed for all the tests except these few. So weird
This comment has been hidden.
passed all except for these Wrong output for '123 ': expected true to equal false
idk where is the bug ?!
See where the closing quote is, there you have 3 digits and a newline char.
Wrong output for '1234': True should equal False Wrong output for '098765': True should equal False
passed all except for these two, seems to me they should both be true.
spoiler, yes it was a hiden char of some sort showing up. most likely a newline, but why?
Not a kata issue. And it's not hidden, see the error message.
This comment has been hidden.
This comment has been hidden.
try it with fullmatch, see my post above yours.
ATM machines don't have '-' or '.' on the keypad. Why is that something we would need to check for?
This comment has been hidden.
Print the input.
I did, the input is a string thats why I'm comparing == and not === because js converts it and if it contains alphabet it should not pass check for if typeof pin == 'number'; maybe I didnt understand you right?
The pin is always passed as a string, see the sample tests.
This comment has been hidden.
Too late to add such requirements as it will invalidate all solutions
This comment has been hidden.
"
Expected true to equal false" means your function returnstrue, but it should befalse.See where the closing quote is, there you have 3 digits and a newline char.
when the code tries the value ("-1.234") it returns true when expected false which sould not happend so I tried the same EXACT code in Console.WriteLine and it returns the expected false result
same problem, how did you solve it?
This comment has been hidden.
First of all, you need to return the result, not print it to console. You can also print the function argument to find out which one fails.
You should explain what a valid pin is besides saying its length and no letters/special characters. You're not explaining that they can't all be repeated numbers OR that it cant be sequential numbers.
Why? That's not tested here.
On test cases, no it is not. But on submission, the extensive tests, it is. i.e. 0000 & 098765 both fail
And both of them, at least in Python, you didn't say which language you're talking here, expect
True, so? There is no such rule in this kata.ahh, yes, that might be helpful information to provide on my part. This is with C#.
In C# they also expect
true.This comment has been hidden.
Got it.
This comment has been hidden.
Notice that there's a trailing new line, not a number (which still makes it 4 characters long). You're testing it with different string on VS.
Not a kata issue, but problem with your code.
Also, please check before raising issue a number of completions in your language (at the top of page or details page). For C# there's 5000+ completions, so you should know it's definitely not kata's fault when number is that big.
GEEAZk
This comment has been hidden.
This comment has been hidden.
I have a problem with this specific one "1234 " Thing is my regex works perfectly in a console project if for all of these "1234\n", "1234 ", "1234\r\n" or @"1234 " So I'm having trouble seeing what's the issue
I've been having trouble with the ones that start 'XXXX
This comment has been hidden.
Hello, I am writing in c# code. It all passed except "1234 " I can't tell if that is a space at the end of 4 in one of the tests?
See where the closing quotes are, that's a new line.
This comment has been hidden.
No, your code has some problems, and you can see it fails with some of the sample tests too. For instance
"0000".This comment has been hidden.
No, check where the closing quote is, and your regexes are wrong.
This comment has been hidden.
This comment has been hidden.
Please use spoiler flag next time, You're missing where the closing
"is. It's been asked and answered before.This comment has been hidden.
I don't even use codewars any more because I spend more time trying to solve the error of woring with codewars than the question. I swear I just wrote code that will pass in my terminal and I just get an error on this site. Its such a waist of time now.
If you can't properly explain what's wrong there is nothing that can be done about it. Probably your code is just wrong.
Agree swordfist
This comment has been hidden.
Those aren't the input values of the tests your code fails. See where the closing quote is.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
The name of this Kata is "Regex validate PIN code", perhaps it should actually require the use of a regular expression to pass?
This comment has been hidden.
I believe it has to do with my .every() method. I will try to do it differently.
Never mind, I found out that it had to do with my bottom if...else statement.
still not sure what to do though...
This comment has been hidden.
Actually just forget all my comments I'm doing it differently
Yess! i figured it out! I was doing it completly wrong.
This comment has been hidden.
Maybe that's your problem. Instructions do not suggest that you should do this. They do however say what should be done for these characters.
this is my only test case which is falling again and again
same bro, same
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
https://github.com/codewars/codewars.com/wiki/Troubleshooting-your-solution#how-do-i-post-to-a-kata-discourse
This comment has been hidden.
Not a kata issue. Return the result, not print it.
Printing vs returning isn't the only problem there. Look where the second quote is in those error messages, the input of those tests isn't
'1234'or'098765'Well this strings are of not 4 or 6 length if you try to print their length respectively, just try putting condition on length of string also
This comment has been hidden.
Try passing "-1.234" or "a345" to your function (both should be invalid).
Your if condition is wrong. Even when fixing that, your code doesn't check the validity of the digits. Btw,
pinis already a string.This comment has been hidden.
This comment has been hidden.
Because it will return true for pin like "-123" or "a23456".
aha thanks!
This comment has been hidden.
Everything: wrong type check, wrong length check, absent content check. Also, not an issue.
This comment has been hidden.
There's a lot of things wrong with your code:
This comment has been hidden.
https://github.com/codewars/codewars.com/wiki/Troubleshooting-your-solution#print-input
This comment has been hidden.
You can add
console.log(pin)to see the input.Edit: actually the inputs are shown in the logs... did you read the error messages?
This is the output:
STDERR /runner/frameworks/ruby/cw-2.rb:60:in
block in describe': Expected: false, instead got: true (Test::Error) from /runner/frameworks/ruby/cw-2.rb:46:inmeasure' from /runner/frameworks/ruby/cw-2.rb:51:indescribe' from main.rb:6:inThanks!
My bad, I thought you were doing JS version, and ruby version has simpler logs. You can still log the input to console (
puts pin).It works now! Thanks
and you can use
pwhich prints with a newline and (just learned this) returns the value of the object being printed:Ye I got confused cuz It was showing "123" but actually it was "123 " with empty space.
Did some space removals and it worked. Ty!
Cool, TIL.
You should add a test that explicitly checks that a five digit number is invalid. I got a solution which returns true for a five digit number to pass all the tests by repeatedly clicking Submit until the random tests didn't check for this situation.
Hi,
I fully agree with this. Unbelievably I was criticised for inserting a similar test in a kata I authored.
This comment has been hidden.
This comment has been hidden.
I did not understand that "123 " means "123\n". It looks like a space but it is \n. If you do not understand this you cannot complete the challenge. \n counts as a character meaning new line.
I don't understand, how can I solve this?
Perhaps reading this might help ~~ Also not a kata suggestion
This comment has been hidden.
I think this is an issue... Test Failed Wrong output for "1234 " Expected: False But was: True Someone can help me?
No it isn't, read the posts below, it's been already asked and answered before.
thx!!!
This comment has been hidden.
This comment has been hidden.
I'll tell you the obvious problem, if the length is 4, it can't be 6 and viceversa right? Your function always returns
false.You've just got to use a different operator, this same thing caught me for a sec too!
This comment has been hidden.
See where the closing
"is, there is an escape sequence there.Not sure I understand what you mean... No clue what's wrong with closing "
I tried to add sth like \r, but no
Try checking the length of the string too.
This comment has been hidden.
Read this. See where the second
'is, there is an special char there.This comment has been hidden.
This comment has been hidden.
in the test with "123". It icnludes "\n" after it "123\n". So check it too.
can solve the map without regular expressions ???
There is no requirment for RegEx.