6 kyu
Secret Agent 101: The secret password
Loading description...
Fundamentals
Algorithms
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
super fun kata, thank you for your time!! ^c^
This comment has been hidden.
Needs some random test cases!
Hello, thanks for your feedback! I have added a few more test cases with random strings for both parts of the kata, I think they should cover all possible cases but I'd like to hear your opinion on the matter.
still needs random strings as test cases
Now, 12 out of 47 are random string test cases (I added 6 more). I believe that they should adequately test the code now.
This comment has been hidden.
I see, thanks for the explanation, I did not understand it before. I'll implement them asap.
Again, thanks for the feedback.
I have now implemented random tests for both functions and cleaned them up a little. I have also made a few changes to the description and requisites of the "decrypt" function, and I believe that not all previous solutions will work now, so check it out if you want!
This comment has been hidden.
Perhaps the "decrypt- part" is not the best, see my solution;-)... made no issue, but have a look...
Thanks for your feedback! That is a completely different approach than I had thought of, and it looks much better, although a little "outside" of the requirements in the description!
@smile67 Your code is too long, Man~~ hahah~~
:-) Yes, little bit more, but it's not my goal to produce the shortest code - "King of short, compressed and often difficult readable code";-)! It's always nice to see this very compressed code, but the shorter it is, the more it is difficult to read (generally). It's often marked as "Best Practice", i know, but who would really use this code in productive environment? Far away from "clean code" and often far away from "quick understanding" (by the way, my code here is also not the best and far away from my productive code which i did not on tablet;-)). Perhaps 95% aren't able to understand it or switch it away because it takes too long to get it. Isn't it better to produce code which is short (perhaps some lines more and perhaps because it's only hobby here and mostly nearby job), but readable for 95% included the "beginners";-)? And last but not least, the shorter it is, means not that it's better or quicker - to do something "once linear", perhaps with stack operations for example (don't know the problem) or to do something "20 times linear" with different regexp and often bad use of linq (which makes debugging and error handling not easier) is not always the best... Wow... much text:-)..., but i often thought about it while reading different code examples on codewars:-)... and perhaps 95% have a different opinion;-)... So keep smiling, everything is just for fun (here):-)!
@simone.ferrero: Yes i know (little bit "outside" the requirement), but sometimes it is the fun of it;-)... By the way a nice kata;-)!
@smile67 Cheers mate :)