Retired
Find the GCF of Two Numbers (retired)
354 of 1,169Shadows of Time
Loading description...
Algorithms
Logic
Numbers
Data Types
Mathematics
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
This kata is a subject to deduplication process here: https://github.com/codewars/content-issues/issues/64 . Please join the discussion and help us identify duplicate kata and retire them.
Retired
Python tests are missing
itblocks.Java actual and expected are swapped. Opening an issue to edit the kata.
assertEquals(Kata.findGCF(8,20), 4); expected:<8> but was:<4> Error?
The assertion in Java should be:
assertEquals(4, Kata.findGCF(8,20));, so, yes, that's an issue. The post below yours says exactly that.Note: the expected and actual values in the Java test cases are swapped, so debug output states that "expected (the actual value produced) but was (the expected value)."
Ruby translation kumited :) please check and approve ~~
This comment has been hidden.
You see, I actually don't know an inkling of Haskell so I just assumed that since the provided solution and test cases passed, it would work. There are some random tests involved, maybe those give negative inputs. How would I fix that?
I would assume that you can use absolute value to get all inputs to be possitive. But it might be a better idea to get in touch with the original creator of the haskell part. (I am a beginner myself, so I'm not sure if i would be of any help.)
Hi, sorry for late response I didn't get any notification about this. Issues is fixed. Regards, suic
Haskell translation kumited.
Sorry, just saw this now. Can't find it, can you link it in a comment?
Here's the link. Thanks
Approved!
This comment has been hidden.
This comment has been hidden.
Sorry, that was changed after my Kumite. I just changed it to the original state.
C#-Translation kumited!
https://www.codewars.com/kumite/579e67c57cb1f3638e00027b
Please check and approve!
I almost approved it, but got an error message. I modified the description a bit and added C++, so maybe you need to update your translation?
Can you try it again?
Still cannot be merged.
I created it as an new translation:
https://www.codewars.com/kumite/579f0033bb99444036000653
Please try to approve this.
Approved!
YEAH! Great!
Python translation Kumited!