Beta
Swedish National Identity Number
17phille97
Loading description...
Algorithms
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Lovely kata, thank you very much for your work! :) I've encountered your kata after your previous changes and it seems pretty clear to me.
This comment has been hidden.
Thanks! It should be fixed now :)
Confirmed the fix :)
This comment has been hidden.
This comment has been hidden.
I answered in the other thread.
Thanks! I love constructive criticism, it's what makes us better. ;)
Marking this suggestion as resolved for now.
It seems
00YYis considered a valid year :I think this case should be described in description. ( Should we considered every year from 0001 to 2016 ? )
; ) )
Hi! Shouldn't all years between 0000 and 9999 be valid as long as it's a valid date?
This comment has been hidden.
This comment has been hidden.
Yeah, you guys are right.
@kazk @ZozoFouchtra What do you think if I put this in the description and update the testcases accordingly?
Or should we make it simpler? Only allow years between
1900and1999?Scrap that! I just got the official validating rules that swedish tax agency uses :D
This comment has been hidden.
I updated the description, but I don't have time to update the unittests now (writing this on my lunch break). I will polish the description and add more and better unittests when I get home ;)
I´ve updated the tests.
Marking this question as resolved for now :)
Hi, it's always good to have some random tests;-)... I think there's a little mistake too, 1974 should be yy=74 and not 97 (description).
Thanks! It should be fixed now ;)