Retired
Go Shopping (retired)
4 of 15rom4eg
Loading description...
Object-oriented Programming
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
No random tests (at least in python).
Description is useless. This is a reverse engineering kata.
The description could use a little more detail, but PLEASE can you write some sensible failure messages for your tests - it took me ages to figure out that the
show_cartmethod was responsible for checking whether the bill was too high, and that that was why the test was failing.Also - I have no idea where the
get_cashmethod comes into it all. There's no test coverage for it, and I managed to implement a working solution without needing it at all.Apart from that - a nice kata. Always enjoy the ones that require proper OO design rather than fiddly little code-golf ones.
thanks for the feedback, I'll try to handle all your suggestions once have little bit more time. please do not judge so hard :)
This comment has been hidden.