Retired
Andy's coffee addiction (retired)
162 of 433jen-harris
Loading description...
Fundamentals
.avif)
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Hi @jen-harris, I've added some random tests to the Javascript version, hope you don't mind. This should now solve the issues on the kata. The Ruby and Python translation already have random tests :-)
A little nitpicking, all return strings have an ending (
!), except for"You can only have an espresso, latte or a decaf now", maybe a.afternow.Having completed your 3 authored katas, none of them seem to have random test cases so far which are essential to being approved. I would recommend checking this out: https://github.com/codingforeveryone/READMEs/blob/master/codewars/random-test-cases-for-complete-beginners.md
If you are still lost, I am happy to help! :) It's tricky to get your head around but important to your katas.
Sorted :-)
Typos on lines 1 and 9 to correct: 'Unfortunately'; 'Create a function that returns THE following:'.
Fixed
Your Kata (JavaScript version) needs more extensive test coverage to prevent easy cheap-cheat solutions and/or logically flawed solutions. The most common way to increase test coverage is through the inclusion of randomly generated test cases at runtime so please add these. The lack of test coverage in a Kata as an Issue is recognised as an official CW stance.
Sorted :-)
The description
Espresso = 1 shotperhaps should have saidespresso(lower 'e') to match the values passed.I've quickly fixed this while sorting out the translations I submitted :-)
Python and Ruby translations submitted :-)
If you scroll down through the tests you can see the code you have written for solve the Kata.
I think it maybe a Codewar error! I've checked other translations done by other people and their main test have overwritten the example tests too :-)
Well that was weird, all four translations I submitted a few hours ago, the main tests had overwritten the example tests....all fixed now. Thanks for letting me know :-)
@adrian.eyre and @daddepledge -- that bug is being fixed now: https://github.com/Codewars/codewars.com/issues/876
Your instructions have a typo in
which cause errors with the tests if you use the sentence as-is.
Thank you!