7 kyu

These are not my grades! (Revamped !)

1,399kingcobra
Description
Loading description...
Object-oriented Programming
Debugging
Fundamentals
View
AllIssues2QuestionsSuggestions1Show Resolved
  • Please sign in or sign up to leave a comment.
  • a.m.1001 Avatar

    This comment has been hidden.

  • Unnamed Avatar

    This comment has been hidden.

  • smithlo Avatar

    I have no idea what does this quiz what me to do. Can you put some example like what's the expected output?

  • Unnamed Avatar

    There are no final tests passing a non-empty grades to __init__.

  • Blind4Basics Avatar

    I think you should explain just a bit more what would be the normal behavior and make some changes in the tests. The goal of the kata is quiet interesting and absolutely valuable, but its "form" does not serve it well because this type of error can be quite painful to identify for beginners.

    • description : explain that the new grades are added at the end of the list
    • change all the test.expect to test.assert_equals and provide the expected value. Yes, that will make your kata easier (a bit), but I believe doing so will also save you a lot of angry messages and complaints from beginners. Let's just look at the satisfaction rate right now... If the kata stays like that, it will never go out of beta.

    Ease the way for the warriors. The idea behind your kata is very important to managed, so it will be faaaaaaar more usefull to everybody if you do not hide it behind other difficulties (for example, I had to implement the __str__ method and modify the sample tests to dig into the problem)

    'Hope this will help.

    Cheers!

    EDIT: I just took a look at the tests: you can hide the average tests if you want with expect, but not the ones that test for each elements of the grades list, in my opinion.

    • kingcobra Avatar

      Thank you very much, once again! ;)

      I added some examples in the description that should help make the kata more approachable. I also changed the tests from .expect to .assert_equals. However, for some reason the example test cases won't update and my modifications aren't showing... any idea what could be causing this?

      EDIT : Nevermind, the example test cases should be ok, now. Sometimes I get this weird error where I'll modify the test cases, re-publish, and not see any changes in the actual kata.

      EDIT : Tried to change the example test cases again and they won't update. Tried unpublishing and republishing, logging out and logging back in, no change. Weird.

      Suggestion marked resolved by kingcobra 8 years ago
    • Blind4Basics Avatar

      That's perfect!

      FYI: when changes are made by a sensei in the example tests, one has to reset them in the trainer to see them (example tests and code of the warrior are saved together so that one can "come back later" without starting again from the beginning, but that present the drawback you just encountered)

      cheers!

    • kingcobra Avatar

      Thank you very much! :)

  • ahmed-h-abdelhadi Avatar

    For those who are riddled by this kata, you can google "mutable default arguments", I hope this helps

  • Voile Avatar

    Needs random tests.