7 kyu
Query Converter
223Huy Dang
Loading description...
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Do we need to handle url with no params?
Nope based on the random tests
Well, I rewrote the random tests, so this answer is kind of an empty tautology (if I knew it's required I'd have added that to the random tests).
Ahhh okay, I thought you asked this question before completing the kata ^^
Approved
I also slightly changed the random tests to give random amount of params.
Thank you for your help and advices. I will take note of it.
Needs random tests.
Yea, I will try to add that in soon
Don't wait too long. While your kata is lacking random tests it will accumulate bad ratings, and people may or may not come back to change those ratings once you have implemented random tests. You really should have had them from the beginning. It was rather predictable that the issue would be raised, and it's as predictable that some people will rate the kata badly because of it. ( And aside from the lack of random tests, it's a nice little kata. I'd hate to see it fail because of something so simple and so predictable. )
Honest question, because I genuinely don't understand: what were you thinking, publishing a kata without random tests?
This is the second one that I have ever published. I am so sorry for the lack of random tests
Added :D
;-)