Draft

Reduce position

12josemanuel.rincon
Description
Loading description...
Fundamentals
View
AllIssues1QuestionsSuggestions1Show Resolved
  • Please sign in or sign up to leave a comment.
  • Blind4Basics Avatar

    Again, unpublish temporarly your kata before it gets more and more downvotes and republish after update.

  • Blind4Basics Avatar

    Hi,

    Your kata is lacking several things or has problems:

    • function name shouldn't be dir because it's a function in python (dir(list))
    • maybe an argument name a bit more explicit...? (not really a problem)
    • the return type as a list is really not a good idea because the order is important. You should either ask for a dictionary or specify the order in which the directions should be appended to the list
    • what about several "residual" directions? (see above)
    • not enough tests
    • need random tests

    cheers

    • josemanuel.rincon Avatar

      hi,

      I agree with you, and i am working to solve it

    • Blind4Basics Avatar

      WARNING:

      I don't know what your doing/what you did, but the kata is completely flawed, currently (all solution invalidated)

      Advise:

      • unpublish whil you haven't finished your updates, it will avoid A LOT of useless complaints to you.
      • do not put fonctions in the preloaded part (I see a cord in the preloaded part, but it sends currently an error. Maybe a problem of partial update, I don't know)