5 kyu
Romanize Russian Road Signs
49bdupau
Loading description...
Strings
Algorithms
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Ribs road (Рёбрышки дорога) Expected: 'Ryebryshki doroga', instead got: 'Rebryshki doroga' ????
ё after consonant letter no vowels
There are too many cases to catch by random tests. Currently you solution is correct, but the other 3 (including mine) are not. It looks like one of those problems where all combinations can and should be tested, something like:
(
assertEquals
only for failures to avoid too much output.)Very good point. I should've figured that 200 random cases don't necessarily cover these 68^2 possible combinations. I'll address this soon, by either testing all combinations like you suggest or all relevant types of combinations (e.g. there is no real added value for testing the combination
РС
).I added a combination test based on your suggestion.
You should specify precisely what the Cyrillic vowels are, it's not obvious to an outsider looking at the alphabet.
Hmm I figured people could easily google that. But perhaps I can add a link to this lesson. The part about Consonants and Vowels is pretty clear. Would that suffice, do you think ?
"The consonant letter й is sometimes called a semivowel."
Pretty clear is not perfectly clear. Why not just be kind and state in the description "The vowels are а, э, ы, у, о, я, е, ё, ю, и"?
In fact I think this is where I went wrong in my solution, I guessed that й was another vowel.
You are right. The Cyrillic vowels are specified in the description now !
It looks like
ʼ
should be preferred in this case: https://en.wikipedia.org/wiki/Apostrophe#UnicodeThanks for the suggestion. You should be able to use both
’
andʼ
for the Latin transliteration of the soft signь
and the hard signъ
now.