Beta

Queens and Kings Stable Marriages

Description
Loading description...
Algorithms
  • Please sign in or sign up to leave a comment.
  • Voile Avatar

    This comment has been hidden.

  • Voile Avatar

    testBestMatchBigRandom needs to have the test assertion rewritten: if test failed it returns Test failed without providing any feedback.

  • Ruslan-dev-Free-Fire Avatar

    After completing a kata and attempting to confirm the completion, I received the following error:

    java.lang.AssertionError

    at org.junit.Assert.fail(Assert.java:87)
    at org.junit.Assert.assertTrue(Assert.java:42)
    at org.junit.Assert.assertTrue(Assert.java:53)
    at QueensAndKingsTest.testBestMatchBigRandom(QueensAndKingsTest.java:136)(...)
    

    This error occurred when I was trying to confirm the completion of the kata. It appears to be related to a test case in the "QueensAndKingsTest" class, specifically in the "testBestMatchBigRandom" method.

    • Blind4Basics Avatar

      not an issue: this just means your solution doesn't handle all cases.

      edit: on the other hand, if you can extract the exact kind of input that makes fail your code, maybe it can be interesting to add it as fixed test.

      Issue marked resolved by Blind4Basics 2 years ago
  • Jakub Kierzkowski Avatar

    When I attempt to pass the full test suite I get the same error for all the test cases. I looks like it's a bug in the test class, or some misleading info.

    java.lang.ArrayIndexOutOfBoundsException: 1

    at QueensAndKingsTest.isOptimalMatch(QueensAndKingsTest.java:163)

    at QueensAndKingsTest.testBestMatchSingleSolution(QueensAndKingsTest.java:25)

    (…)

  • Voile Avatar

    isOptimalMatch is missing in the sample tests.