Beta
Queens and Kings Stable Marriages
Loading description...
Algorithms
View
Career Accelerator
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
This comment has been hidden.
testBestMatchBigRandom
needs to have the test assertion rewritten: if test failed it returnsTest failed
without providing any feedback.After completing a kata and attempting to confirm the completion, I received the following error:
java.lang.AssertionError
This error occurred when I was trying to confirm the completion of the kata. It appears to be related to a test case in the "QueensAndKingsTest" class, specifically in the "testBestMatchBigRandom" method.
not an issue: this just means your solution doesn't handle all cases.
edit: on the other hand, if you can extract the exact kind of input that makes fail your code, maybe it can be interesting to add it as fixed test.
When I attempt to pass the full test suite I get the same error for all the test cases. I looks like it's a bug in the test class, or some misleading info.
java.lang.ArrayIndexOutOfBoundsException: 1
at QueensAndKingsTest.isOptimalMatch(QueensAndKingsTest.java:163)
at QueensAndKingsTest.testBestMatchSingleSolution(QueensAndKingsTest.java:25)
(…)
are you sure you're returning an array of appropriate size? (I bet not).
isOptimalMatch
is missing in the sample tests.Thanks, just fixed.