Beta
There must be only one...
14ben8p
Loading description...
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Running the code sometimes gives an error. In my case the first time I tried the code it gave an error bit the second time it passed. I suugest that you look into this
Random tests are too weak to the point they're irrelevant to the type of problem in this kata.
Keys being random does not mean anything to a kata where the order and type of set/get operation matters.
This comment has been hidden.
Testing seems limited. WHat happens if we set
a
totrue
, then tofalse
?The sample tests are limited, but the real tests are random. the rule is 0 or 1 can be true. (i will update the description)
No, they're not.
And they don't test that corner case either. Or truthy but not
true
values.I meant what I said, and I was talking about the Submit Tests.
Should be fixed now.
Test.assertEquals
is supposed tobe a strict comparison or am I missing something ?https://www.codewars.com/docs/js-slash-coffeescript-test-reference
Yes,
assertEquals
does===
. I have not a clue what that has to do with anything.It's still not random.
It's also still not checking corner cases.
Tests are supposed to enforce the specs. ZED fails that by not checking the
set
value. ( Voile does the same BTW. I suspect both of 'em of are doing it on purpose. :P ) And random testing means random output, not just random input.My bad, I see waht you mean. I overlooked the problem. I did extra changes and it should be fixed now.
You're still doing things in unrandom patterns.
I give up.
Can't you just point out which piece isn't random instead of being passive-agressive ? I made extra changes (even if I don't see the point of having them) to get random state for the key. So now : generated keys are random, key count is random, values for keys (true or false) are random, keys switch true/false are randome, amount of read/write to key is random.
Is there something more ? Please pin-point...
You want one? Okay, I'll raise one.