Retired
A New Era (Japanese Calendar Conversion) (retired)
18ritz-w
Loading description...
Strings
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Hi Ritz-w, enjoyed the Kata. Just a quick change to make -- you've pre-loaded a function to the user's window that's called calendarConversion rather than nengoConversion, as is required for the tests to work. I learned something about Japanese dating, thanks!
This kata is unsolvable. Tests are broken.
Tests also expect different results than specified.
Thank you for the feedback. I believe I've fixed the tests. Would you like to try again?
It's solveable now. Now you desperately need random tests. ( Before this gets retired because of abysmal ratings. The idea is nice enough, but the implementation is killing you. )
Thank you again for the feedback. I've put in a few random tests now. As you must be able to tell I'm totally new at this, and appreciate all the advice I can get. If you might be willing to give me more pointers, what else do you think might help me to optimise this? Cheers
More complete coverage of possible ( and impossible ) inputs in the random tests would have better chances of uncovering possible bugs in solutions.
For this kata, this is enough though.