Retired
Broken seven-segment display (retired)
Loading description...
Puzzles
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Naming convention:
sevSeg
--> ``sev_seg`your lists aren't ordered correctly, meaning that your random tests enforce useless boilerplate to keep the order of the original lists (or even to find how to order them...). As suggested by Voile (but as an issue, so), please use a good design for the task => use sets.
seems to be done.
There are too many random tests. 25000 tests isn't going to do anything other than choking user's browser on every submission.
If you want complete test coverage just perform all the combinations in the fixed tests.
The broken digits should be a set, not a list, because we do not care about the order.
Similarly, the returned result should be a list of sets ;-)
.
What is a invalid input? It is not mentioned anywhere, and it could be anything (String length not equal? Some input not strings? String contains invalid characters?).
Returning
-1
is a bad design. It makes your code incompatible in other languages.Plesae use proper design and throw an exception instead so others will learn the right thing ;-)
Dont rely on user solutions that will define a CORRECT
SSD
for your, copy your own in the complete testThanks for the feedback!