Beta
Find heroes
37 of 63x3m
Loading description...
Strings
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
The description says we need to "extract" names, but not what that means. Or what is to be returned by the functions.
The sentence "as a set of strings" has been added to the description. This is enough?
Missing lots of edge cases as fixed tests: empty strings, one letter names, capitals within names, and probably more I can't think of right now.
This comment has been hidden.
you should remove the last line of the description: you're orienting users in a direction that is not necessary.
done
Error messages are very cumbersome to read.
Test.assertDeepEqualsshould be used instead.Or go
Node 10.xandchai.assert.deepEqual, while you're at it.done
Random tests are very weak.
yep. @x3m: you should look at other (recent) katas you solved to see how you should implement them.