Beta
Ferris Wheel Cabins
57Tiarama
Loading description...
Algorithms
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
very wonderfull drawing, I felt positive making this kata, tnx
Impressive first time kata Tiarama - fun too!
I think I've solved it, thanks for the feedback!
yes and no:
I've implemented all of this now - This is my first kata so sorry for the messiness and thanks for the feedback!
Returning
0
in the exceptional case is a bad idea - that value can also result from an inexceptional case ((0,0)
).-1
would be a better idea. Or throwing anError
. Or returningnull
( an empty value ), though not everyone will agree with that.-1
orthrowing error
is better,null
is worse (because, it is still multiple output types, and such code removes type hints from IDE, if you're using any).IMHO throwing an error is better than returning some arbitrary value.
I changed the exceptional case return value to -1
Thanks for the comments, I'm learning a lot