5 kyu
All Expressions Matter
17mirkeau
Loading description...
Fundamentals
Algorithms
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Currently the return type is
a, notMaybe a, so this sentence doesn't make sense.Thanks, fixed! :)
Reference solution is wrong.
From a random test:
expressions [(+),(*)] [-5,1,-1,-2,0,-1,-6] `shouldBe` 90-5 * (1 + -1 * (-2 + 0 + -1)) * -6 = 120You're not doing any intermediate trimming are you?
Thanks, I'll have a look!
Should be fixed now! :)
Looks like it! :]
This is my very first kata. I'm looking forward to feedback!
How about tests with
Booleans?I will add some, thanks! :)
I added some random boolean tests! Thanks!
I'll make a fork of your tests and refactor some. I think readability can be improved somewhat ( though some of it will - again - be just because I'm more used to seeing it how I'll be writing it. there are some de facto standards for testing on CW ). Not now, but soon.
I like that you have an
instance Show $FUNCTIONSa lot!That's great, looking forward to it!
Fork
Of course I tried to do everything .. :O