Beta
Prostate cancer recurrence rates (Phoenix)
47GitQuick
Loading description...
Arrays
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
the function name in the initial code is
recurrence_ratebut the tests expect it to be namedrecurrenceThank you for this! I altered it from recurrence_rate to recurrence but missed that spot. corrected
When I run 'Test' or 'Attempt', this raises an error with the tests :
Traceback (most recent call last):File "tests.py", line 3, in module
from solution import recurrence
ImportError: cannot import name 'recurrence' from 'solution' (/workspace/default/solution.py)
not an issue - you altered the function name
actually, seems like the solution set-up is wrong?! my apologies for closing
Yeah seems... I didn't solve the kata but in set up the function name is
recurrence_rate, which is I guess incorrect... Can someone who solved the kata confirm?Solution corrected thanks for picking this up
Issue from below reopened: this solution should not be able to pass: https://www.codewars.com/kata/reviews/624e3d7aae3ae80001857121/groups/62513c36e8e2060001442478
Thank you for identifying this. I realize now I should (obviously) have not compared floats the way I initially tried.
This comment has been hidden.
Thanks added, very good idea
not ok: see this solution: https://www.codewars.com/kata/reviews/624e3d7aae3ae80001857121/groups/62513c36e8e2060001442478
Thank you. added a hardcoded case to test this as well as approx 5% of the random cases
The 'Output' that you provide for the first two examples in your description are NOT correct (see below). The answer to the first problem should be False and the answer to the second problem should be True.
Input: [7.91, 2.43, 1.49, 0.99, 0.74, 0.48, 0.52, 0.50, 0.66, 1.26, 1.36, 1.35] Ouput: True
Input: [9.98, 8.56, 4.62, 1.16, 0.26, 0.37, 0.32, 1.02, 0.99, 1.56, 1.41, 2.35], Ouput: False
Thank you good catch- fixed!
Example block in the description says
ASTRO, but this is the Phoenix kata.Thanks reference to ASTRO removed
Reference solution used in random tests check for
> 2.0, not>= 2.0.great catch, thank you- fixed
Why return a rounded percentage as integer when we can just return the count? Or even better, why not just ask us to write a function to check one patient instead? There are a lot of hoops to jump around the core task in the kata.
(This also applies to the other kata.)
I sincerely appreciate this feedback. I have changed the kata to check one patient and I think that improves it significantly. I would be grateful for any additional feedback if you had another look