Draft
Cornhole Score
13 of 16jrs80
Loading description...
Games
Algorithms
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Who approves my translation? It has a (critical!) issue about random tests, who almost returns only one answer.
I fixed it now, no more questions.
Thanks for doing the translation!
description input format doesn't match the test case format.
from description:
Team A -> [3310,0011,1301,3333,1331,0001,3130]
from test suite:
Team A-> [[1,3,1,3], [3,3,3,0], [3,3,1,1], [0,1,1,0]]
I guess I didn't intend that to be so literal, but point taken...description fixed. Thanks.
This comment has been hidden.
Please explain.
Well, for starters: without much further thought I ran the
ATTEMPT
by simply coding no more than:return 'A';
(in C#) and it happened to pass all the random tests.This comment has been hidden.
Okay, this should be fixed now.
To me description was real pain and is necessary to do redo. I read it at least 5 times. Would be good to put it in points. Is not necessary to have this "Far far away" style. If something in description is not necessary delete it. Maybe these interesting facts about "Cornhole", put it in link there like "if you are interested in past of game and ...". I fully believe that riddle a description is not a part of katas :D.
IMHO - it is ruining very very good kata.
Example of the "error part" in description. (Clear, nothing more than necessary).
Error is when: • Final score of any team is bigger than 21 • Arrays are not exactly 4 • Are used digits different than 0,1,3 • Arrays have not same length
Thanks, those are great points. I've modified the description to (hopefully) be more concise and clearer about input/output/etc.
Very nice. It is like chalk and cheese :). Great work (y)
The error test check in the actual tests are pointless because all composed test cases will fail the broad "one team reaches 21 points" check, hence failing to check for the other specific edge cases. Checking for 21 points only will also pass these tests.
Fixed, I believe.
Also, the kata's missing random tests.
Also fixed.
Why does the test for error only contain 2 integers in the array? Each array should have 4 integers according to the description.
That's why it's an erroneous score...
Except you didn't define what is considered "erroneous score" in the first place. The only condition mentioned is "final score isn't 21".
Also, anything that is being tested in the sample test should go to the text fixture too. The actual tests do not perform this check.
Ok, thanks, I'll work on that.
fixed.