Retired
Browser tabs (retired)
Loading description...
Logic
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Maybe you should write in the description that
1Kb = 1000b
,1Mb = 1000Kb
, etc.? I'm asking that because usually one kilobyte equals 1024 bytes (althought formally it's 1000), so I got confused by the seemingly wrong tests lolI thought the same, but it turns out we're both wrong. (In this kata , formal values are used)
Information from google:
But I will add this to the description, thanks for the feedback
i
is used to denote the usage of 1024 as a base. These are read askibibyte
,mebibyte
, an so forth. i.e.:Uppercase
B
is used forbytes
, whilst lowercaseb
is forbits
.There is no right or wrong, many different systems are used, even some that mix base 2 and base 10. Just pick your reference and make sure the description is clear.
This is currently not tested.
It is tested, my bad.
False
Thank you for such a detailed review, it will help me improve my kata.
All the problems mentioned above (except, of course, a possible duplicate) have been solved
Thanks, much better now.
What I meant by duplicate in this case, is that the essense of the task has already been done. The essense of this task is parsing and converting between units, and there already are multiple kata that cover just that. The one I linked above is specifically about information units, but there's also more kata about converting between other units.
For that reason, I'm not a fan of this kata. Other users might not feel the same as me though, so feel free to keep the kata public to collect more feedback.
I understand you and appreciate your opinion, thanks for the feedback
No sample tests, also the description looks broken
All the problems mentioned above have been solved
Thanks, now I don't have any issues yet :)
"yet" scares me)
Don't be scared, now the kata is really fine :)