Retired
52 Card Pick Up (old) (retired)
Loading description...
Puzzles
.avif)
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Every solution, including author/reference solution, assumes that the input contains no duplicate cards; they don't agree with each other if a valid card is duplicated in the input. But this assumption is not specified anywhere.
Thank you for your feedback. The current solution is not checking if there is only one deck but rather if there is indeed at least one full deck in the pile (if a card is found a second time the solution still sets the dictionary value to 1). The description does state the goal is to return True if a full deck is found, but I can add a rule stating, "There may be duplicate cards as well, ignore the extras"
This comment has been deleted.
You could, but maybe you should discuss the kata first on Discord.
This comment has been hidden.
This comment has been deleted.
.
In python function names should be snake_case
It is now fixed. Thank you for your feedback.
Please avoid heterogenous collections as inputs and outputs, because they make your kata harder to translate and can result in really bad translations, especially to statically typed languages. I think it should be easy to find a string value which would mean that a card landed on the ground
This comment has been deleted.
How is this "more difficult"? Adding more nuisances doesn't make something more difficult (and, if anything, make it less enjoyable).
And anyways, if you really want "no cards", don't use
0, useNone.Fair point, although many Kata make you deal with strings and integers. Would using None still maintain the "heterogenous collections"? It would not be that hard for me to change 0 the integer to "0" the string and make all elements of the inner arrays strings. (or even just use "Z")