5 kyu
Your family tree
18 of 29jpssj
Loading description...
Trees
Recursion
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
This was great! The work put into the description and tests was very much appreciated!
Thanks!
If different enough from this kata, a followup kata could have a person have two parents. You can then have multiple relationships to the same person in some cases. Your sister could be your mother etc ..
I have something like that (about cousin marriage) in my drafts. I've put it aside some months ago but I will brush the dust in the coming days. ^^
I changed the last batch of big tests from
100 tests with max 9 generations and max 5 children by personto10 tests with max 9 generations and max 4 children by person. The last version of the big tests was only possible because I missed to pass a parameter somewhere, so the tests weren't really what was announced. The new batch of big tests seems more adapted.Random tests sometimes have 10 generations difference while the description has a hard limit on 9.
That should be fixed.
appears fixed to me too
In the last batch of random tests, the test output crashes on error and it's impossible to find differences in this bulk of text. You should think of another way to show the biggest test cases in the console
Another option is to abort random tests early on first error.
You're right, and I don't know how to fix that (I'm thinking about that since the beginning). I will ponder it again tomorrow and come back with a solution as soon as possible. (Edit: will take account of your last suggestion.)
there should be an easy fix, have a look at Python test guidelines to abort early: https://docs.codewars.com/languages/python/codewars-test
Thanks for the tip : now, normally, the tests abort after the first fail in the 9 generations batch.
looks good
These are unacceptable: are we secretly doing a "translate a number to English word" kata again? (Not to mention both word and ordinals are involved)
They should really be in a format that doesn't involve translating numbers to English words, because they're completely separate tasks unrelated to the core task of the kata.
great-great-great-grandmotherand the likes are still acceptable, but definitely not these English word numbers.The goal of this kata, besides to work on tree data structures, is to solve a real genealogy problem. And 'once removed', 'first cousin', 'second cousin twice removed', etc., are the words used to talk about, and to solve, those kind of problems in genealogy (I didn't put a link to a genealogy site because I wanted the kata to be self contained). So I think that's appropriate and related to the task.
Okay, at least we know from the description the maximum number of numbers we need to support (read: hard-code). Not ideal, but ehh
Hasn't this been done a couple of weeks ago?
I don't think so but I don't follow closely the new katas so that's still a possibility. If you think about my Teknonymy kata, both are indeed about trees, genealogy and kinship but, algorithmically, they are significantly different.
yes that's the one! since you authored it, I'll take your word for it these are different kata's