Beta

Flagging Down the Answer

17samannetts88
Description
Loading description...
View
AllIssues3QuestionsSuggestionsShow Resolved
  • Please sign in or sign up to leave a comment.
  • Blind4Basics Avatar

    ok, better. Now, please:

    • rename "randomized tests" as "random tests" (which is not the same thing)
    • Remove at least half of the existing fixed tests.Basically, everything you added thinking it was random tests.
    • in the random tests, compute the expected result before calling the user's function (otherwise they can mutate the input)
    • increase the number of random tests to 100 (the usual number of them)

    Cheers

    • samannetts88 Avatar

      Thank you so much for your help on this! Really clear explanations and guidance as to how I can improve this. Very much appreciated!

      Please let me know if you have any other thoughts, otherwise I'll mark this as resolved later today.

    • Blind4Basics Avatar

      yeah, one last: you should Object.freeze(...) the full_flag_list object (which should be called FULL_FLAG_LIST in the tests, since it's a constant), otherwise it also could be mutated.

      You can close the issue once it's done.

    • samannetts88 Avatar

      Amazing, I've made this change so will mark the issue as resolved. Thanks again for everything, I learnt a lot through this so I'm very grateful to you!

      Issue marked resolved by samannetts88 last month
  • Blind4Basics Avatar

    The random tests are not random...

    See the documentation or the tests of some recently approved JS kata if you don't know how to implement them.

    • samannetts88 Avatar

      My mistake, apologies for the confusion and inconvenience! The latest addition of tests should cover this random requirement.

      Issue marked resolved by samannetts88 last month
  • Mednoob Avatar

    No random tests