Thank you so much!

I copied over what you wrote and continued the rest. I didn't understand that this is what you wanted at first.

Sorry for the inconveniece. Please let me know if this is good.

Hi Abiyasash12,

In order to illustrate how I think the description can be clarified, I forked the problem here. I rewrote the beginning of the description in a different way. See if you like what I wrote. If so, you can copy it over into your version, and then rewrite the rest in a similar style.

Those of you who have completed this kata please give feedback and rate the kata (not satisfied, somewhat satisfied, or very satisfied).

If not satisfied, please let me know in the discourse here.

Thanks!

Sorry about the invoncenience. As you can see in the description now, you must make the hue to 0 even if it is 360. This will avoid possible confusion.

I also added the first test case in the random tests above as a fixed test.

Sorry for the issues!

Sorry, the 10k tests was only when I was testing it. I was a complete goofball and forgot to get rid of it.

As for the hue values, I'll start working on that now.

Possible reasons for low satisfaction votes I can see are some technical issues:

• 10k tests is a lot. Why is there this many tests needed?
• Some tests expect hue of 360. Is this a valid value for hue? If yes, how should I know when to return 0, and when 360?

Random Tests
  For rgb (234, 41, 42):
    expected '0, 82%, 54%' to equal '360, 82%, 54%'
  For rgb (230, 8, 9):
    expected '0, 93%, 47%' to equal '360, 93%, 47%'
  For rgb (253, 95, 96):
    expected '0, 98%, 68%' to equal '360, 98%, 68%'
  For rgb (177, 52, 53):
    expected '0, 55%, 45%' to equal '360, 55%, 45%'
  For rgb (214, 93, 94):
    expected '0, 60%, 60%' to equal '360, 60%, 60%'

I'd also like to know why I have three not satisfied votes so I can improve upon my errors.

I'm confused, should I include the formulas to convert RGB to HSL in the description or am I good?

I fixed the pawn captures. I don't think any other moves are illegal, but please check me on that. I'm most likely wrong. Thanks for the feedback though!

It seems I forgot to remove those lines of code to print out the random tests. I was just doing that for testing purposes.

I'll make sure to fix the pawn captures as well. Thanks!

Don't worry - my first few attempts at creating kata were all rejected. You learn how to do it by experience. Unfortunately, some people don't provide helpful feedback - they just give it a low rating. Also, chess kata are not always very popular. I have created quite a few - some were approved, but some are still waiting for enough people to try them.

Nice job including en passant. Fortunately it wasn't too difficult to modify my program to handle it.

Two more suggestions: Don't print out the random tests. It clutters up the output window. My last suggestion is harder: some of the random tests are illegal moves, like cxg6. I think it only happens with pawn captures, but I haven't thought about it carefully. If you can fix it that would be great!

Can you guys please help me and provide some translations for this kata? I'd appreciate the support.

Could you tell that this was my first kata? I didn't know much about how to do these things.

After a while, people stopped doing this kata, and I didn't remember to fix these things.

Thank you for making this suggestion. I followed all of your suggestions and I fixed the issues.

I also included en passant, it should be in the description. Thanks a lot!

This is a fun kata. Some suggestions for improvement:

Re-order the description by putting the examples first. Currently, text like "If the move gives check, add a "+" symbol" is confusing, because the program is not actually supposed to do that. State at the top what the input and output are. Then show what the program should output, given specific input moves. As you do each example, explain how Algebraic Chess Notation works. It's the same basic content, but re-structuring it in this way will make it clearer.

An example of how pawn captures work should be included in the description.

The sample tests should include some cases of piece captures and pawn captures.

It would be nice if, when a hidden test fails, the input move is displayed. This helps the user debug their program.

Instead of testDeterminedNotation(), a simpler name is fixedTests(). Instead of testRandomNotation(), a simpler name is randomTests(). And there should be more than 7 of them.

Is there any reason that you didn't include "en passant"? I don't think it's that difficult to add. But overall this is a great contribution to the kata related to chess!

oh my bad they still didnt fix the issue from 5 yrs ago for some reason