Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Hi,
Just a suggestion but the tests may need to include cases other than "foo". Seem like I was able to hardcode it and still pass all the tests.
This comment is hidden because it contains spoiler information about the solution
This was a great kata, overall.
But I would definitely write up some more tests that include other classes being inherited by base classes.
for example.
There is a solution that passes your tests but doesn't pass this one so I had to improve the solution.
So to prevent the incomplete or incorrect code from passing and making this kata a bit more complete, I would add up those tests.
Regardless of that - Excellent stuff!
invalidated
Excellent kata, kudos!
I'd like to suggest adding a test case such as:
test.assert_equals(find_uniq([ 'ab', 'ba', 'abc']), 'abc')
Reason: That was the only test my code couldn't pass. My solution was based on unordered "startswith." So to prevent solutions akin to mine from passing, adding the above test case would be ideal.
Plus, the assert with "the first element" should be a little mixed because, in that case, my broken code wouldn't be able to work either.
e.g.
test.assert_equals(find_uniq([ 'ba', 'cbc', 'ccb', 'bcc']), 'ba')
Having fixed all the bugs in my code, I just wanted to let you know about the lack of test cases I spotted in this kata. I hope you appreciate my comment. Kind regards
This comment is hidden because it contains spoiler information about the solution
Thank you for the report. Please review:
https://www.codewars.com/kumite/61e58f44e4b7d600453a7afe
This comment is hidden because it contains spoiler information about the solution