Ad
  • Custom User Avatar

    Multi-digit formatting rule is not specified.

  • Custom User Avatar

    Input type is not suitable for the task because dict does not guarantee key order, and a certain order is expected out of the keys in the results.

    It should either be a list, or be an OrderedDict (a bad idea), or the key order should be explicitly specified.

  • Custom User Avatar

    It is not mentioned that dices can have different number of faces.

    But then, why is there a test case of 2 keys in the actual tests? A dice can't have 2 faces.

  • Custom User Avatar

    In the sample tests the keys are strings, but in the random tests they are numbers. This should ideally be consistent, or a note should be made that keys will be of different variables types (and then list the types).

  • Custom User Avatar

    Could do with more coverage in the basic tests. I would add:

    • A test with all zeros
    • A test where the first item has the most rolls
    • A test where the last item has the most rolls
    • A test where an item in the middle has the most rolls