Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
First, you should never claim something is faster without actually benchmarking it. Python has many hidden optimizations in built-in functions.
Second, I guess my solution would be faster in most cases because
any
stops at the firstTrue
, andall
stops at the firstFalse
, so it would only reach the end of the sequence if it consists of all equal elements. Your algorithm will reach the end in any case. Consider the situation[True, False, ...(10000 elements more)]
. My algorithm will stop after checking the first two elements; yours will check all the sequence in any case.On the second thought, it would be faster in any case except, maybe, some very short sequences, because the first value of predicate would be either
True
orFalse
, so one of theany
orall
functions is guaranteed to stop after checking it.For your solution, I missed the iterator part in map. yes, the space complexity will be O(1) but then it is a slower iteration over sequence. a simple loop should be faster. Mind me I understand that they both are O(n) time complexity but simple loop should be a faster O(n) out of those two. let me know what you think.
This comment is hidden because it contains spoiler information about the solution
How exactly creating new structures in memory can be more efficient? This solution has O(1) space complexity.
i think counter method is more efficient space wise. however , it has same time complexity
Unnecessary parentheses.
Bad
Fixed
added two instance of add![x, y]
I suggested 2 instances of
add![x, y]
with different values ofx
andy
at runtime. Of course, that would still be hardcodable, but just a bit less straightforward...I can see the problem now but i am afraid i have no ideas of how to stop this problem. Please suggest me if we have standard way of avoiding this problem in codewars.
Thanks in advance.
This comment is hidden because it contains spoiler information about the solution
Added two test cases without values in error messages
How about some tests to make sure solutions aren't hardcoded based on error messages? Something like
Loading more items...