Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
This is not true ( anymore ) and should be taken out.
Tests are vulnerable to input modification.
If you like your object equality, the pieces should be ( individually ) frozen. Object equality is actually unnecessary, and deepcopied pieces could be passed, but that's probably more work.
Lua translation!
suggested tags:
promises
,asynchronous
Random tests are not actually random; they pick from a small bag of fixed test cases.
This also prevents the kata from having more random tests; currently there are only 15 per submission, which is definitely too few.
I find the design of
Process
nonsensical:start
/stop
andpaused
/resume
are independent of each other. However you can't pause something that's not started, and if you stop something paused it should not be considered paused anymore.These should be handled by
Process
itself, notSuperphoreMaster
.The last two test groups (
From Maya: 0 through 20
andTo Maya: bounds & random
) are bugged: they contain elements that areMayaPieces.chunkZero
instead of[MayaPieces.chunkZero]
.Returning
false
when no data is present is a terrible design choice, and it really should be changed to return an empty array instead.The last sentence of the kata description reads: 'To uncomplicate things, there will be no punctuation in the phrases.'
However, the sample tests include punctuation.
@Austin Haws, translations for C, C++, Java, & NASM are ready for review.
What's the expected result of
bittyWords('So long, and thanks for all the fish', 64)
?long
orlong,
?Currently passing 722 tests but failing 2. It may have something to do with the note for the
startUsing
method.To be clear, does this means that if the
process
object is currentlyProcess {started:['resource1'], paused:[]}
, it should then beProcess {started:['resource1','resource1'], paused:[]}
whensuperphoreMaster.startUsing('resource1', number, process)
is called?Then, after calling
superphoreMaster.stopUsing('resource1',process)
, theprocess
object should revert back toProcess {started:['resource1'], paused:[]}
?EDIT: the failed tests are part of the test group
multi lock same resource -> lower priority queueing several times
.