the arrow syntax is the modern one

Correct, but it's usually used for one-liner, short functions (or anonymous functions). For functions with longer body, regular function declaration should be used (well, I guess it depends on your coding style). There are also differences of what this refers to, so it's not like 1 way is conclusively better than the other.

like this: functionName = parameter => functionBody

Well, congratulations, you just introduced a global variable. If you don't want to do that, you need to declare functionName with const/let: const functionName = (...) => ...;

Var is actually old syntax

And this is why it confuses me: you're trying to suggest "modern syntax", but you're using outdated "var" as an example. Can you see why I would have an issue with that?

Using global variables and "var" = "modern syntax"? Yikes.

k seems to be a single digit number, and n is only up to a few million (7 digits) long (Python version), so if you're getting timeouts, you should reconsider your approach.

What in tarnation is happening here?

Yay, I found the easter egg :D But now I'm stuck :(

changed

fork addressing all remaining suggestions.

fork addressing all remaining suggestions.

The entire formatting of the kata should be revisited.

You should highlight the character limit in description. Right now it's kinda buried at the end.

Isn't this the exact same kata as the one you linked in description?

when there are 0

When there are 0 of what? Arguments? Quantity? It doesn't matter how many there are, you need to add every category to the result (even if there's no books). Printing function arguments might help.

I ran your current code and a random test with stocklist = ['WQHXKEHMJC 201', 'LYUYOJBCUT 158', 'BDZVLXTMTA 562', 'KQBYGDDWLL 928'], categories = ['R'] returned '', when the expected result is '(R : 0)'. The result is based on categories, and seems correct to me.

There's no issue with kata results that I can see, but feel free to reply.

• No random tests
• Duplicate

Approved.

Approved.