Ad
  • Custom User Avatar
    • None of the ciphers are explained in the description
    • It's not clear what "reverse characters by word" means
    • There's no point in using a class here
    • No random tests
    • Throwing many ideas which have all been implemented in different katas into a single task doesn't really make a good kata overall
  • Default User Avatar

    Random tests almost always expect False.

    A function that simply returns False will pass after few tries.

  • Default User Avatar

    Sample test is wrong and confusing.

    • function result is not tested
    • test.expect(True) does not make sense (always pass)
    • a call that should return False followed by expect(true) is very confusing
  • Custom User Avatar

    Nice kata, but please fix the exmaple test case as pointed out by @SteffenVogel_79. Also, it would be beneficial for users to show the tests input values instead of having to print them out for debugging.

    Additionally please follow python coding standards and change the function name to saving_Lives

  • Default User Avatar

    Hi,

    Typo in the second line of the description (I suppose) : "directory" instead of "dictionary".

    About the kata itself, this seems not logical to store ['None'] instead of a simple empty list when the number is prime: if no factor, len(list) == 0 makes more sens/be better practice than if no factor, len(list) == 1 and lst[1] == 'None'. I think you should modified your kata about this point.

    Regards,
    B4B