Nice kata, but please fix the exmaple test case as pointed out by @SteffenVogel_79. Also, it would be beneficial for users to show the tests input values instead of having to print them out for debugging.
Additionally please follow python coding standards and change the function name to saving_Lives
Typo in the second line of the description (I suppose) : "directory" instead of "dictionary".
About the kata itself, this seems not logical to store ['None'] instead of a simple empty list when the number is prime: if no factor, len(list) == 0 makes more sens/be better practice than if no factor, len(list) == 1 and lst[1] == 'None'. I think you should modified your kata about this point.
Random tests almost always expect
False
.A function that simply returns
False
will pass after few tries.Sample test is wrong and confusing.
test.expect(True)
does not make sense (always pass)False
followed byexpect(true)
is very confusingNice kata, but please fix the exmaple test case as pointed out by @SteffenVogel_79. Also, it would be beneficial for users to show the tests input values instead of having to print them out for debugging.
Additionally please follow python coding standards and change the function name to
saving_Lives
Hi,
Typo in the second line of the description (I suppose) : "directory" instead of "dictionary".
About the kata itself, this seems not logical to store ['None'] instead of a simple empty list when the number is prime:
if no factor, len(list) == 0
makes more sens/be better practice thanif no factor, len(list) == 1 and lst[1] == 'None'
. I think you should modified your kata about this point.Regards,
B4B