In general, no it's not good practice to put everything on one line. In this case, it's fine. This is a very pythonic solution, this would be just fine as is in almost any codebase (depending on usecase).

is it good practice to put everything in one line? it's elegant, but may get hard to read, once things get complicated.

I had exactly the same solution!

Cara, gostei muito da sua solução.
Sinceramente me fez pensar em como eu ainda tenho que melhorar, porque a minha resposta teve algumas linhas a mais, mas isso só serve de incentivo para continuar evoluindo

a

I don't know how that would be more time efficient since the time complexity is O(n * c) where c is the number of vowels. Ie it has to loop through the entire string for every value because of replace method. The given solution is O(n) complexity.

Dude, why your code return "<generator object dis_trol at 0x00000186174DBB90>"
instead of a string

Same. Best platform for learning imo. Mad I didn't sign up sooner.

I was thinking the same thing. Kind of just started learning python, I hope I could do that someday :')

I realized our answers were similar here, I mean, most of them are, but still xD

That a very interesting solution you have provided here, really made me think more efficient

good answer

This is a good example of why it's important for a Python, and coding, noob such as myself, to go beyond the glitter.

I want to thank all those who commented concerning runtime, etc. It's helps a noob like me to stay grounded.

and using .lower introduces error. i think this person just asked chat gpt and threw it up bc this is what gpt wrote me when i asked hahaha