your string is never nul-terminated because the line-ending logic has precedence over the nul-terminating logic in your if/else

it is now explained in the initial code

OP solved it, closing

why are we giving address of "i" in "for(auto &i : q)" ??

but the parameter of atoi is string( int atoi(const char *str) ).so why are we giving the address of elements as a parameter?

Use of regular expressions is efficient for pattern matching.

Editing an approved translation doesn't do anything useful.
Forking usually is the preferred way, someone will have to approve the fork.
Editing the kata is also possible, but it can cause problems in the future if someone forks the translation not noticing direct kata edits.

thanks,i was tried to otherwise. but i surrender triying. sorry about my english is very bad

Check the length of the string before trying to access something.

Help. when i test the code i aprove without error, but when i try to pass the full test, i get an error(IndexError: string index out of range). i don't know what is wrong

Sorry! I will fix that, but would I edit it or fork my translation? Will it get automatically changed or will it have to be re-accepted?

Will fix once I understand how to edit it properly. Thanks for the feedback

@ethan67 Lua: a test with an empty ending should be added.

exactly i also having the same issue. in my visual studio code it is showing false but here it is showing true. idk why