Ad
  • Custom User Avatar

    the key is (each letter appears the same number of times (not necessarily just once))👍

  • Custom User Avatar

    You should have added fractions, now it's 8kyuish)

  • Custom User Avatar

    Fixed in OP's fork

  • Custom User Avatar

    Approved

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    python new test framework is required. updated in this fork

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    Needs true random tests. The current "random" tests just consists of different values of the same route.

    Also needs more fixed tests. There is only ever 1 route hash tested for the kata.

  • Custom User Avatar

    The methological and design of the kata is incorrect: segments refer to URL segments, which is the path of the URL further delimited by dashes. Hence a method named .segments should not return the named hash, it should return an array of the URL segments. The named segments would be the params captured by the route.

    Even then, storing the params in the object as a mutable state on Router is insane design, because it doesn't belong to Router, but specific to a request itself. Instead of returning ["CommentsController", :edit] and storing { slug: "test-post", id: "12" } into .segments the method should really return ["CommentsController", :edit, { slug: "test-post", id: "12" }] (with empty hash or nil as the third element when no named segments exist). Every MVC framework does this so the action will actually get the params as it is invoked by the framework.

  • Custom User Avatar

    Test.expect should not be used.

  • Custom User Avatar

    could add FUNDAMENTALS tag

  • Custom User Avatar

    Are these the lengths of two its sides?

    Yes, what other thing could they be?

    Can there be a non-2D triangle?

    Not in this kata.

    Complete the method that takes two numeric arguments, which represent the dimensions of a 2D rectangle as floats.

  • Custom User Avatar

    Before trying to solve this kata, I don't understand how two numeric arguments represent the dimensions of a 2D rectangle. Are these the lengths of two its sides? Can there be a non-2D triangle?

  • Custom User Avatar

    In the description, I would specify that the first length is meant to be the longer one.

    The random tests expect 'False' when the first number is smaller than the second one.

  • Custom User Avatar

    Nowhere, and it's been already asked below.

  • Loading more items...