Ad
  • Default User Avatar

    In the test category "LengthTests" I think instead of "some-horribly-long-domain-name-this-time-longer-than-63-charaters.zzz" the given text should be "some-horribly-long-LEVEL-name-this-time-longer-than-63-charaters.zzz".

    As the level name is longer than 63 characters I think the result for this test should be false not true.
    BUT I am not quite sure because it is not clear from the output which test of the test category it refers to.

  • Custom User Avatar

    Python fork with random tests and standard failure messages: https://www.codewars.com/kumite/64b321a2206744001d337b9e?sel=64b321a2206744001d337b9e

  • Custom User Avatar

    Python: tests use test.expect, what makes failed tests emit poor failure messages.

  • Custom User Avatar

    Python (at least): no random tests

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    Hi,

    I encounter some weird things, in the python version. Meanning: things that seem incoherent with the description (but maybe I did not understand what was said...) :

    • "Top level validation must be naive - ie. TLDs nonexistent in IANA register are still considered valid as long as they adhere to the rules given above." => I understand that '' as TLD is valid, but see example tests : not validate('.codewars.com') => !???
    • "Top level (TLD) must not be fully numerical" => but validate('1234.com')) is excpected to be True => !??!!??
    • and that seems not coherent with validate('127.0.0.1')) which is expected to be invalid...

    Seems to me that is inconsistent... Or what did I miss ? (I'm a bit lost, here...)

  • Custom User Avatar

    [PHP Version] Good code coverage with plenty of fixed assertions and a few edge cases but it would still be good to see random tests implemented sometime to further prevent hardcoded and/or logically flawed solutions from passing. Anyway, consider your Kata approved :D