Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Description says "Only positives integers will be used", yet 0 is generated sometimes.
Im not at this top level stuff but how do you access the Foo() class within the test cases? If I try making my own it doesn't work as the test cases require the class object specifically initilized within the test cases its self.
the link in the description points to the docs for Python 2.7, which is quite ancient. it should be upgraded to more recent docs
This was a great kata, overall.
But I would definitely write up some more tests that include other classes being inherited by base classes.
for example.
There is a solution that passes your tests but doesn't pass this one so I had to improve the solution.
So to prevent the incomplete or incorrect code from passing and making this kata a bit more complete, I would add up those tests.
Regardless of that - Excellent stuff!
This kata needs random tests.
This comment is hidden because it contains spoiler information about the solution
I think the description could do with more polishing.
I, for one, fully expected the tests to cover corner cases such as
property
objects,classmethod
orstaticmethod
objects, or custom descriptors. :-) Perhaps make it a little clearer in the text that this is not going to be required?Random test which is not enough
https://www.codewars.com/kata/reviews/54bec5636150e1db650000fe/groups/5dbe51eb65a61b000151dd22
There could be more test cases, at least for nonempty function arguments.