Ad
  • Custom User Avatar

    Haha. Thanks for the suggestion :-)

  • Custom User Avatar

    Great to hear :), you're welcome.

    Good luck with the next one, it's much tougher. :)

  • Custom User Avatar
  • Custom User Avatar

    After actually attempting the C++ version I found several more issues but I fixed them myself. Now there's a new problem which I didn't put much thought into and thus ignored, but it really should be changed.

    Since I'm already a contributor I can adjust my code and simply replace the user's and reference solutions, or the author could try fixing his monstrocity himself. @anter69 what do you think?

  • Custom User Avatar

    @anter69 approve the fork, it seems to be alright now.

  • Custom User Avatar

    I'll wait for FArekkusu's feedback before resolving the issues, but thanks :-)

  • Custom User Avatar

    Please see the above issues and fix them ;-)

  • Custom User Avatar

    There is a ton of useful stuff in Guava and Apache Commons which are available on CW :)

  • Default User Avatar

    Great, you did find a problem with the kata after all:

          //std::string result = encode_solution(s);
          //Assert::That(encode(s), Equals(result));
          std::string result = decode_solution(s);
          Assert::That(decode(s), Equals(result));
    

    The random decode testing had the encode function(s) called for both the user and the reference solutions. You can see the above changes I've just now made to resolve this issue. Thanks for the feedback.

  • Default User Avatar

    I just tweaked my C code and ran it through the C++ translation and made it work. The test suite seems to be working fine. Please note that more than 600 coders have solved this in C++. To properly show evidence of any issue with this translation, you'll need to provide: the input, the expected output, and what your code returned.

  • Custom User Avatar

    Hi ElectricZatch. You would need to solve the kata in a language that is currently available first. You can then submit a translation for review but it must have several random tests included.