• Custom User Avatar

    Removes refsol and adds vague levels of sanity to test generation. Also switches to longs so that tests can match Python.

  • Custom User Avatar

    nvm I forked it myself.

  • Custom User Avatar

    Ok.. uhm.
    so what you did might be technically correct, but .. could you please write it how it is in python? because what you wrote looks like you gave up on implementing it as intended.

    also, you seem to have edited the already approved translation, normally the button to edit that is not even visible so I'm not sure how you even did that, maybe you manually added /edit to the url. regardless of how that happened, that change isn't live.

  • Custom User Avatar

    @natan, you are right, I fixed it

  • Custom User Avatar

    I don't see any further details I could share. Those are the details. Your test gen generates cases that do not have a solution.

    Which is to say, they do not satisfy the property in the kata description

    I have four positive integers, A, B, C and D, where A < B < C < D. The input is a list of the integers A, B, C, D, AxB, BxC, CxD, DxA in some order.

    instead it is:

    picking 4 random values that don't relate to each other

    for ( int i = 0; i < 4; i++ ) my_list.add((int)(Math.random()*range) + 1);
    

    there are examples of such invalid test cases in the open issue above, another example of an invalid test case that your test gen may generate is [1, 1, 1, 1, 1, 1, 1, 1]

  • Custom User Avatar

    @natan, could you explain in a little more detail what the problem is?

  • Custom User Avatar

    @Featres test gen generates invalid input, note requirements in description on input and lack of enforcing that in the gen code, instead picking 4 random values that don't relate to each other.

    .. last seen december, ~2months ago, though.

    kinda wish we had bit of an ownership/accountability/nosy system going on with notifications and such, instead of like here, having people not notice issues popping up within one month on their translations/approvals.

  • Custom User Avatar

  • Custom User Avatar

    Raw HTML is discouraged, using Markdown should be preferred: [link title](link url).

  • Custom User Avatar

    Thanks!

  • Custom User Avatar

    <a href="blablabla">lorem lorem</a>

  • Custom User Avatar

    How to post 'Java Translation' link instead of actual link?

  • Custom User Avatar
  • Custom User Avatar

    @Featres just delete function solution() (not imported) — that should be enough

  • Custom User Avatar

    Hey, thanks for feedback, I really appreciate it. I'm still learning :))).
    I tried to correct it. Could you take a look. Thanks in advance!

  • Loading more items...