Rejected by someone

Oh thanks, I had already found that. Added random tests

Good point, I refactored to just take in the BigDecimal

It is a note for best practice when working with currency values in Java.

Passing in currency values as Strings rather than BigDecimals is already not following best practice, so what's the point?

Can you expand on what you mean by no random tests?

I didn't say that it wouldn't work. It is a note for best practice when working with currency values in Java.

Use BigDecimal, since the primative type double or Double are not precise enough for currency.

This is not actually true, since this is never tested; using double can also pass the tests.

In fact, all the inputs are integral values, so even using int can pass the tests.

No Random Tests

Those tests have now been removed

If a negative number is entered your code needs to return -1.

There's no such requirement in the kata.

There are tests for large numbers meaning that a brute force attack should time out and cause a failure.

There's no such requirement in the kata.

A mix of spaces and tabs is used for indentation.

Thanks! I forked your Java translation and recreated the original test cases. Everything else has been flawless

I will give you two int arrays each with a size of 4. These will be the end points of the line.

In what format? 4 numbers can mean anything.

I didn't even pay attention, but your tests aren't enough:

{0,0,100,100}, {0,0,100,150}: both our codes would return true, for this!

and note that once you'll corret that, you'll need to handle floating point errors.

hi,

Sorry, but your kata is way too much of a classic (we already have sevral katas about that kind of stuff). Moreover, it's lacking random tests.