Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
It has been added in front of the
async
function name to make it clear that it is an asynchronous function. Also the description has been modified to make it clearer.Thank you very much for the suggestion
Both the name and the description have been modified.
Thank you very much for the suggestion
Added the chai configuration. Thanks
Random transaction generation has been added to avoid all tests being run on the same data.
Thank you very much for the suggestion
Example code responses have been added in the description, and the relationship between each of the actions with the function has been added.
Thank you very much for the comment
Misleading initial code:
amountPositiveTransactionsByDate
is asynchronous, while others are synchronous. Asynchronous should be marked withasync
keyword.Then this should not be called
positive amounts transactions
, and the function name as well: "positive amounts" is contradictory with "equal to or greater than zero". This causes the expected result to contain entries with0
amount.chai.config.truncateThreshold
should be set to0
(otherwise we cannot see the transaction content in the failed assertion message).Now the actual test just uses a fixed set of data for all the test cases (and expects a fixed value). This is unacceptable.
Hi again,
How? 4 different functions? a class? a single output of one function? The user should know upfront what they are actually facing, without needing to open the trainer. For the same reason, the description is currently lacking an example of ouput (at least one)
Cheers
Ah, that makes more sense
I created the solution description wrong. Fixed, it was the average per character. Thanks for the feedback
Solved, I have removed the call to a non-Codewars server/API.
I'm honestly perplexed how you're computing the average word count? None of the transactions have a word count over 50. How is the average 194?
Hi,
A kata cannot rely on a server/API of an user. What becomes your kata once your server is suppressed, in a bunch of years, when you're not an active user?
=> unpublishing.
Cheers
Loading more items...