you should have handled array overflow

Thank you!

Yes, see it for yourself:

https://docs.python.org/2.7/library/functions.html#round

https://docs.python.org/3.5/library/functions.html#round

Not the best practice cuz any other type of n then int will return -1.

Didn't event think of catching errors on these fundamental tasks...I like it.

Not the best practice as any other errors that are not due to IndexErrors will still return -1. Its best to return -1 ONLY when index is out of range.

Got it. Thank you very much for your help!

Josh

hmm.. i think you need to get some undrstanding of pass by value / pass by reference in general. And how it works in python.

You can check something like this: https://www.geeksforgeeks.org/pass-by-reference-vs-value-in-python/

Hope you'll answer your own questions after this =)

I'm a little confused by array[n].

Isn't this used to look up in a list/dict?

array is a parameter. Don't we need to create a list first?

I'm new at this.

Thank you very much!

Josh

bare excepts are a good example of what not to do. So this is exactly NOT best practice.

I agree on both counts; catching exceptions is good and handling expected states is great.

In case of negative index it's definitely the best practice.

PEP8: "Never use the characters 'l' (lowercase letter el), 'O' (uppercase letter oh), or 'I' (uppercase letter eye) as single character variable names."

Not best practise IMO, better to be explicit and check the length of the array before indexing