Ad
  • Custom User Avatar

    I know the code will still work, that's why I tagged this as a suggestion and not an issue.

    I'm very new to JS, so maybe I'm not used to seeing a variable with the same name as commonly used functions and/or data structures. But in my experience in other languages, this is not best practice.

  • Custom User Avatar

    The parameter is the JavaScript translation should be called something other than map.

  • Custom User Avatar

    In the JavaScript translation, the answer for the following is expected to be { black: 5, white: 2 }. Could someone explain where the second white comes from?

    answer = [1, 1, 1, 2, 2, 2, 1, 1, 1, 2, 2, 2, 3, 3, 3]
    guess  = [3, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
              w  b  b           b  b  b
    

    For comparison, I've used the following, which expects {black: 1, white: 0}

    answer = [1, 2, 3, 4]
    guess  = [1, 1, 1, 1]
              b
    
  • Custom User Avatar

    You are a young human lady and your fiancé is an ogre. Today is his anniversary and he would love to visit the tournament

    Why am I engaged to an orge that's already married? Surely, I can do better.

  • Custom User Avatar

    There is STDERR in Javascript

    assertSimilar is deprecated, use assertDeepEquals

  • Custom User Avatar

    This problem still exists, at least for Javascript. Sometimes the random tests catch it and sometimes not.

    Even when my code failed on the following, it still passed the full test suite.

    Test.expect(!oneCharDifference('abcd', 'dcbe'), 'abcd and dcba differ by more than one letter')

  • Custom User Avatar

    STDERR in Rust translation

    warning: unnecessary trailing semicolon
      --> src/lib.rs:56:10
       |
    56 |         };
       |          ^ help: remove this semicolon
       |
       = note: `#[warn(redundant_semicolons)]` on by default
    
    warning: `challenge` (lib test) generated 1 warning
    
  • Custom User Avatar

    The term "size" in the description is ambiguous for squares since it could be either an area or the length of a side. Additionally, the description is generally confusing (my opinion as well as that of several others in the discussion).

    An improvement would be something like:

    a - length of side of square 1
    b - length of side of square 2
    m - length of x-dimension of suitcase
    n - length of y-dimension of suitcase

  • Custom User Avatar
  • Custom User Avatar

    Nice change from the standard kata.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    In the python tests it's really annoying that you simply get an error message "Value is not what was expected" when your test fails instead of the expected and actual results.

  • Custom User Avatar

    Great problem. It's refressing to see threading instead of the usual iteration or string parsing.

    One small issue is that the times in the sample test are incorrect in the C++ translation. The second comment should be 1.999 seconds and the third should be 2.001 seconds.

    usleep(1000000); Assert::That(calledBack.load(), Equals(0)); // 1 second passed usleep(999000); Assert::That(calledBack.load(), Equals(0)); // 4.999 seconds usleep(2000); Assert::That(calledBack.load(), Equals(1)); // 5.001 seconds

  • Custom User Avatar

    In the instructions it states When various orders have the same price, their quantities are aggregated and all of those orders appear at the same level in the orderbook.

  • Custom User Avatar

    Great alternative to the usual katas.

  • Loading more items...