Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Approved.
This comment is hidden because it contains spoiler information about the solution
Even if you would not go the way I proposed, there are still some things which could be improved in your current translation:
ExtraMessage
It(should_return_false)
into separate, explicit blocks with separate fixed tests for specific input scenarios: negative values, zeros, correct cubes, positive incorrect cubes, etc.Would you please check out this fork with my proposal of some techniques: https://www.codewars.com/kumite/6402634f431f2dd2eb7ee797. This is more or less how I would like the things to be done, but you do not necessarily have to adapt all of them if you think they are, for some reason, wrong.
Much better, thanks! Still, a couple of remarks:
static
(needs to be changed in two snippets).std::cout
, but rather by usingExtraMessage
function passed into assertion. Please see the article I linked for examples and details.side: -5, volume, -125, expected: false
is missing,In general, nice work!
Same problem with decode - SEGV. Didn't check for an empty string.
ok, I found the translation and approved it. Tests are updated accordingly. I didn't get description conflicts, so I hope everything is good...
@Heathro: the changes of a translation are applied only when it's approved.
Oh ok. Good to know...
Is there a link to this updated fork? I don't think you can self-approve it (someone else should do it).
@Heathro: you saw my answer above? (the issue)
(actually, working with forks can mess the things up to, considering how the forking process is working right now, so... For now, there is no "best way"... Hopefully fixed in near future)
Yes I noticed. It's not that bad in this case, and if you really know what you're doing, it's probably ok. But usually it's better to just work with a fork, so you don't accidently mess something up :P (you can see which lines you changed or removed)
na, that's ok if you're the translator.
It's okay for you to fix in editor as long as you know how and what to fix, then all good !!!
Do NOT go around editing other users' katas. If there is an issue, you should raise one, or publish a fork with working tests, NOT editing the kata directly.
It's
C# translation
Loading more items...