The use of Test.expect here is fine: it's just checking if the return value is truthy. Checking of actual values are done via Test.assertDeepEquals.

Test block Should return a non-empty map of player names to the sum of their winnings (or losses) has no test assertions: Test.expect is missing.

• The title should be in english

• Test.expect should be removed

• Node 12 should be enabled

assertSimilar should be replaced with assertDeepEquals in the sample tests.

There're undefined's in the random inputs.

Hi guys, I've added random test to my kata. Thanks for the advice

thanks for the advice. Very appreciate that

Success and failure messages from assertDeepEquals are a lot cleaner than those of assertSimilar.

Also, assertDeepEquals ignores property order within Objects; assertSimilar does not. Property order is sometimes undefined in JavaScript, so testing should not depend on it.

assertEquals is not going to work with Objects; it compares references, not values.

Hi Johan, Thanks for the recommendation. I was going to use assertEquals but did some reasearch about assertDeepEquals. It seems like a better choice.

Just wanted to ask you, from my understanding, assertDeepEquals check if the result is equivalent with expected output, even though they're not the same object. Is there any other reason why you suggested using assertDeepEquals?

Thank you

Yes

Needs random tests

Please do not use assertSimilar; use assertDeepEquals instead.

Paste your code and mark your post as having spoiler content.