Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
It's not the author who gives the kyu but a moderator and there should be different kyu for different languages. Furthermore yo are certainly too good:-)
It is too simple for 5 kyu. It should be 7 kyu not higher.
I found that out as well, just changed the test code to what it should be, but the actual test are broken as well for the last test I get
returns 'nopqrstuvwxy`abcdefghijklm' should equal 'nopqrstuvwxyzabcdefghijklm'
and the rules are that any special character should be ignored, but here it is not.
Python tests are broken.
Traceback:
in
TypeError: assert_equals() takes at least 2 arguments (1 given)
The logic of indexes order is weird. I believe it does exist since a lot of people solved it, but it is weird and poorly described.
Referencing method that does not exist during testing phase.
@I159
,Please understand I wasn't trying to insult your description with my comment about the robots. I have no issues with the story, my point is that the actual kata problem is not unique. Your kata seems to boil down to this: Given a list, rotate it 90 degrees clockwise in-place. All I was trying to say is that both of those other katas also boil down to the exact same thing.
As for checking for uniqueness, I guess it's just a matter of solving lots of problems. The reason I knew your kata was a duplicate was that I had just solved one of the other ones less than two days before so it was fresh in my mind. The same solution for that kata worked for this one too. It can be hard to find duplicates searching by name since everyone names their own katas in different ways.
I can't close or delete your kata, I'm just a regular Codewars user. I was just trying to make suggestions to help keep Codewars katas unique. It can get boring when you are solving the same problems over and over (try searching for Caesar Cipher or Palindrome katas if you want examples). Unfortunately, many people seem to be approving katas strictly for points these days while ignoring outstanding issues and whether or not they are duplicates. I thought pointing out problems and fixing them was the purpose of beta.
I fixed most of your comments and found your tips very useful. I'm not trying to make it unique with any kind of story. I'm not experienced with Codewars and as you may see it is my first kata. So, I don't know how to check my kata for uniqueness. The story is not to splurge you or deceive anyone either. I just noticed that people trying to keep katas fun, especially algorithmically simple ones. Feel free to close the kata or delete or how it could be done.
@I259
,It seems like you're creating the potential identity issue by forcing the function to return a value. You could simply check the original
matrix
list for the required changes, no return value needed. Maybe I'm missing something but where is the identity issue in the example I gave?matrix
rotator(matrix)
to modify it in-placematrix
has been modified as expectedThat's why I left an example. What is the point of checking identity if you can just check the original
matrix
list for the changes? Doesn't that negate the need for identity checks?I'm not sure "checking identity deeper" does anything to change the essence of this kata: Given a list, rotate it 90 degrees clockwise in-place.
https://www.codewars.com/kata/90-degrees-rotation
https://www.codewars.com/kata/rotate-a-square-matrix-in-place
This kata...
I guess you added a story about robots but, other than that, which part is unique?
Thanks for your time!
Hi! Thanks for reviewing. Since I planned to control identity by memory
assert_equals
is not the way because it checks for equality not identity. And actually my test as complicated as it is because I'm checking for identity not just equality. If there is a method which could check for identity I'll be grateful for such a tip.Yep, I see it duplicates the katas. I'm going to check identity deeper to keep it totally in place. Could this modification make my kata unique?
Yes, so sometimes life is really hard:-))! ;-)
got same cryptic message about shovel.js.
; ) )
This comment is hidden because it contains spoiler information about the solution
Ok, have it, was the wrong direction, but very strange error message;-)! Thanks again for testing...
This comment is hidden because it contains spoiler information about the solution
Loading more items...