Ad
  • Custom User Avatar

    the k=0 rule would make sense if the problem was turned into a problem where you have to select the amount of dice with n being the limit
    @_@, but currently for every other output it seems to only care about the sum if u rolled all the dice

  • Custom User Avatar

    You're right, I understood it over time.

  • Custom User Avatar

    Several results make no sense. Like "act(0, 6, 0, 1)": How can you throw zero dices one time? That is physically impossible. You can only reach zero points by not throwing the dices at all, no matter how many you have.
    Or "act(1, 6, 0, 1)": How can you throw one dice with side values of 1-6 and reach zero points? The minimum you can reach with one throw is 1.
    Or "act(0, 6, 1, 0)": You have no dice, but you reach a score of 1 by throwing them zero times? How is that supposed to work?
    Or "act(1, 6, 7, 0)": You can score a maximum of 6 points with a throw, but with zero throws you can score 7 points...?
    My opinion: A target of zero can only be achived with zero throws, no matter how many dices and sides you have. If the target is >0, then there should be >0 dices, otherweise return -1 or "Error". A target larger than the maximum points you can achieve should either be removed or also lead to -1 or "Error".

  • Custom User Avatar

    In Python, import fractions yields fractions == None. This does not seem to be intentional, so I'm assuming something in the import-prevention stuff is broken.

  • Custom User Avatar

    Should be posted under "Issues"

  • Custom User Avatar
  • Custom User Avatar

    Like @crunker99 said above, it's worth noting that this evaluates the expression for every single day. Fine in this case because they're all very cheap, but something to keep in mind.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    I do not understand the logic here. You do not pick how many dice you can roll, it is n dice. There is no way (0 ways) to have a roll sum of k = 0 when you roll at least one die. This outcome should only be possible when both n and k are 0. If you ask for 1 when k = 0 and n > 0, you implictely say that we get to choose how many dice we can roll, which is a different problem than what the kata is asking for. It also makes the sum of probabilities for each k bigger than 1, which does not make sense.

  • Custom User Avatar

    Sample Test Cases & Test cases (Fixed tests):

    1. Assertions must be encapsulated inside the it block, not directly under the describe block [Ref]

    2. Missing solution import

      from solution import sum_circles
      

    Test cases (Random tests):

    1. Should also use test.assert_approx_equals instead of test.assert_equals for approx equality.

    2. Better adjust the it block message (args = ...) so it matches the new parameter name (diameters) of the user solution.

  • Custom User Avatar

    @dfhwze I think k == 0 is reachable iff n == 0. (Take a look at my solution to the current version.)

  • Custom User Avatar

    fixed

  • Custom User Avatar

    fixed

  • Default User Avatar

    especially when you read it as

    s sides numbered from 1 to 0

  • Default User Avatar

    agreed, is this not unlike a vacuous truth?

  • Loading more items...