Ad
  • Custom User Avatar

    C#: method name should be PascalCase (Please refer to implementation of backward compatibility here )

  • Custom User Avatar

    nitpick: a minor typo in the description string as a param[E]ter repres[]enting the expression.

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    One of the tests (which returns an error) says:

    "assertEquals( "Answer for expression '?*11=??' " , 2 , Runes.sol_____________veExpression("?*11=??") );"

    Is that giant space supposed to be there?

    Apart from that, I am receiving errors but unable to think of test cases that invalidate my code.

  • Custom User Avatar

    I got a test case with the following expression:
    "?08644-464194=244350", which expects 7

    But:
    708644-464194 is 244450, and not 244350. Am I missing some detail here?

  • Custom User Avatar

    Go translation (author is inactive).

  • Custom User Avatar

    Rust translation (author is inactive).

  • Custom User Avatar

    In Elixir, some test cases seem broken. All sample tests pass, but some later test in the full suite always fails, expecting a result of 0 when there is no correct result (-1).

    Example:

    1) test Fixed tests More tests (TestSuite)
         test/solution_test.exs:51
         Assertion with == failed
         code:  assert Kata.solve_runes(s) == sol
         left:  -1
         right: 0
         stacktrace:
           (elixir) lib/enum.ex:783: Enum."-each/2-lists^foreach/1-0-"/2
           (elixir) lib/enum.ex:783: Enum.each/2
           test/solution_test.exs:64: (test)
           
    Testing input: "47848+-?39008=-5911?0"
    

    In this case, not only does 0 not solve the equation, but it also goes against the rule that no number will start with a zero.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    Very nice challenge, thank you for the kata. For the longest time I thought the edge case involved a number going out of the range [-1000000, 1000000], but it appears no test case actually checks for this (correct me if I'm wrong). Perhaps remove the range from the description? In my experience it did not contribute towards solving the challenge (C#).

  • Custom User Avatar

    The Expression "-00?*?=-?" should be tested for because negative leading zeros should not be allowed when positiv leading zeros are rejected.
    Both Top Solutions break for this Expression.

  • Default User Avatar

    Need more basic tests. Top voted solution does not test for basic cases such as "?1+1=2", "1+?1=2" and "1+1=?2". Both should evaluate to -1, but top solution evaluates to 0.

    More random test cases couldn't hurt either.

  • Default User Avatar

    Ruby translation without random tests... feel free to improve with them.

    Please review and approve.