Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Error margin is set up
0.55
and5
, butassert_approx_equals
accepts maximum of relative/absolute error, which means the fixed tests accept+-0.55
, and the random tests will accept everything.It also means no training is neccessary to pass the kata: see this
These tests are testing the specific implementation details that was not mentioned in the description at all.
Meanwhile,
calculate_loss
is not tested at all. So it's very unclear what is actually meant to be tested.No random tests. Also percentage is always 100 in the current tests, so the
grade_percentage
method is not properly tested.Trivial kata, a simple class inheritance with some properties and string formatting has been done before.
Trivial kata, finding an item in a list (in a list) has been done before
obstacles
in random tests are in a completely different format: in sample test it isBut in random tests it is something like
In actual tests:
33.333333333333336
is not a integer.The description also never describes how
noiseLevelAtPoint
should calculate its value. Assuming inverse square law and100
initial noise level the noise level would be100 / 2
, not100 / 3
.The tests are coupling
noiseLevelAtPoint
andlocateNoisyStudent
:noiseLevelAtPoint
is only tested in actual tests, butgenerateReports
depends onnoiseLevelAtPoint
, so if it is incorrectly implementedlocateNoisyStudent
will receive invalid input, making sample tests useless. This is a very inappropriate design for testing.