Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
fixed
Beautiful Kata. I created one similar with Template Literals! Check me out!
nice point to consider
In my understanding, this kata doesn't put any restriction on the input strings. So, 'abc' and 'c' are both valid strings. And what I want to comment is the RegEx solution can't cover special cases.
Edit: Oh, now I understand that this RegEx solution is for the old version of this kata, and it was correct. Now the kata has changed, and it's no longer accurate. Anyway, I think we can update the test cases, but the kata's original description should not be changed. Otherwise, the solutions won't be consistent.
Correct, it'll fail.
The author should have added that to the list of test-cases earlier (perhaps to intentionally escape weird inputs).
It's not hard to either use
endsWith
(if available) or implement a trivial linear (O(n)) solution that scans each character from the end of the string.The latter could be then optimized by splitting the ending into two halves and checking first and last characters for each half (that way it'll give negative response faster than a linear solution).
Just for your information, 'abc' and 'c' are both incorrect string literals since they should end with an additional apostrophe.
This solution is not correct for special cases such as:
solution('ab(c)', '(c)');
solution('abc\', 'c\');
solution('abc+', 'c+');
dibley1973, yes, it make sense to apply indentation for inner query.
Jason, use indentation! :)
Definitely agree. Can terminate after 5 matches.
I disagree on the clean/perfect part. It's harder than necessary to read this because the formatting is terrible. Proper indentation would make this much more enjoyable to look at.
However, after prettifying it and working through it I think it's a really elegant solution. Especially compared to a lot of the solutions below it.
The regex flag, 'i', might not be needed.
But the question doesnt explicitly say that it needs case sensitive comparison, although the tests pass without the flag, 'i'.
This comment is hidden because it contains spoiler information about the solution
same issue in clojure version
This comment is hidden because it contains spoiler information about the solution
Clean, nice and perfect. Bravo.
Loading more items...